Re: [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-28 Thread Jarno Rajahalme
> On Nov 28, 2016, at 2:42 PM, Jiri Benc wrote: > > On Mon, 28 Nov 2016 14:29:39 -0800, Jarno Rajahalme wrote: >> I’m not sure what you suggest here. Obviously the kernel ABI can not >> be changed as existing userspace code expects upcalled packets to be >> non-accelerated. Also, if userspace pu

Re: [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-28 Thread Jiri Benc
On Mon, 28 Nov 2016 14:29:39 -0800, Jarno Rajahalme wrote: > I’m not sure what you suggest here. Obviously the kernel ABI can not > be changed as existing userspace code expects upcalled packets to be > non-accelerated. Also, if userspace pushes vlan headers, the packet > will actually have them.

Re: [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-28 Thread Jarno Rajahalme
> On Nov 24, 2016, at 8:10 AM, Jiri Benc wrote: > > On Tue, 22 Nov 2016 20:09:34 -0800, Jarno Rajahalme wrote: >> Do not set skb->protocol to be the ethertype of the L3 header, unless >> the packet only has the L3 header. For a non-hardware offloaded VLAN >> frame skb->protocol needs to be one

Re: [PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-24 Thread Jiri Benc
On Tue, 22 Nov 2016 20:09:34 -0800, Jarno Rajahalme wrote: > Do not set skb->protocol to be the ethertype of the L3 header, unless > the packet only has the L3 header. For a non-hardware offloaded VLAN > frame skb->protocol needs to be one of the VLAN ethertypes. > > Any VLAN offloading is undone

[PATCH net-next 2/2] openvswitch: Fix skb->protocol for vlan frames.

2016-11-22 Thread Jarno Rajahalme
Do not set skb->protocol to be the ethertype of the L3 header, unless the packet only has the L3 header. For a non-hardware offloaded VLAN frame skb->protocol needs to be one of the VLAN ethertypes. Any VLAN offloading is undone on the OVS netlink interface. Due to this all VLAN packets sent to