Re: [PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

2021-01-07 Thread Jakub Kicinski
On Thu, 7 Jan 2021 09:14:17 -0800 Florian Fainelli wrote: > > I can reproduce that after switching from mips to arm64. Before this > > change bgmac.h was not using BIT() macro. Now it does and that macro > > forces UL (unsigned long). > > > > Is there any cleaner solution than below one? > > Do

Re: [PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

2021-01-07 Thread Florian Fainelli
On 1/6/21 12:37 PM, Rafał Miłecki wrote: > On 06.01.2021 20:26, Florian Fainelli wrote: >> On 1/5/21 11:32 PM, Rafał Miłecki wrote: >>> From: Rafał Miłecki >>> >>> UniMAC is integrated into multiple Broadcom's Ethernet controllers so >>> use a shared header file for it and avoid some code duplicat

Re: [PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

2021-01-06 Thread Rafał Miłecki
On 06.01.2021 20:26, Florian Fainelli wrote: On 1/5/21 11:32 PM, Rafał Miłecki wrote: From: Rafał Miłecki UniMAC is integrated into multiple Broadcom's Ethernet controllers so use a shared header file for it and avoid some code duplication. Signed-off-by: Rafał Miłecki --- MAINTAINERS

Re: [PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

2021-01-06 Thread Florian Fainelli
On 1/6/21 11:26 AM, Florian Fainelli wrote: > On 1/5/21 11:32 PM, Rafał Miłecki wrote: >> From: Rafał Miłecki >> >> UniMAC is integrated into multiple Broadcom's Ethernet controllers so >> use a shared header file for it and avoid some code duplication. >> >> Signed-off-by: Rafał Miłecki >> --- >

Re: [PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

2021-01-06 Thread Florian Fainelli
On 1/5/21 11:32 PM, Rafał Miłecki wrote: > From: Rafał Miłecki > > UniMAC is integrated into multiple Broadcom's Ethernet controllers so > use a shared header file for it and avoid some code duplication. > > Signed-off-by: Rafał Miłecki > --- > MAINTAINERS |

[PATCH net-next 2/2] net: broadcom: share header defining UniMAC registers

2021-01-05 Thread Rafał Miłecki
From: Rafał Miłecki UniMAC is integrated into multiple Broadcom's Ethernet controllers so use a shared header file for it and avoid some code duplication. Signed-off-by: Rafał Miłecki --- MAINTAINERS | 2 + drivers/net/ethernet/broadcom/bcmsysport.h| 35 +