Re: [PATCH net-next 2/2] mlx5: convert to new udp_tunnel infrastructure

2020-07-28 Thread Jakub Kicinski
On Tue, 28 Jul 2020 08:35:53 + Saeed Mahameed wrote: > On Fri, 2020-07-24 at 19:51 -0700, Jakub Kicinski wrote: > > Allocate nic_info dynamically - n_entries is not constant. > > > > Drop the ndo callbacks from the reprs, those should be local to > > the same netns as the main netdev, no need

Re: [PATCH net-next 2/2] mlx5: convert to new udp_tunnel infrastructure

2020-07-28 Thread Saeed Mahameed
On Fri, 2020-07-24 at 19:51 -0700, Jakub Kicinski wrote: > Allocate nic_info dynamically - n_entries is not constant. > > Drop the ndo callbacks from the reprs, those should be local to > the same netns as the main netdev, no need to get the same callbacks > multiple times. > Isn't this a proble

[PATCH net-next 2/2] mlx5: convert to new udp_tunnel infrastructure

2020-07-24 Thread Jakub Kicinski
Allocate nic_info dynamically - n_entries is not constant. Drop the ndo callbacks from the reprs, those should be local to the same netns as the main netdev, no need to get the same callbacks multiple times. Drop the udp_tunnel_drop_rx_info() call, it was not there until commit b3c2ed21c0bd ("net