Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-24 Thread Vladimir Oltean
Hi Sasha, On Wed, Aug 12, 2020 at 05:34:30PM +0300, Vladimir Oltean wrote: > On Wed, Aug 12, 2020 at 03:51:44PM +0200, Sebastian Andrzej Siewior wrote: > > On 2020-08-03 18:21:45 [-0700], David Miller wrote: > > > From: Vladimir Oltean > > > > The driver calls napi_schedule_irqoff() from a contex

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-12 Thread Sebastian Andrzej Siewior
On 2020-08-12 17:34:30 [+0300], Vladimir Oltean wrote: > I expect the driver maintainers to have something to say about this. I > didn't test on stable kernels, and at least for dpaa2-eth, the change > would need to go pretty deep down the stable line. Yes, each affected and maintained stable kern

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-12 Thread Vladimir Oltean
On Wed, Aug 12, 2020 at 03:51:44PM +0200, Sebastian Andrzej Siewior wrote: > On 2020-08-03 18:21:45 [-0700], David Miller wrote: > > From: Vladimir Oltean > > > The driver calls napi_schedule_irqoff() from a context where, in RT, > > > hardirqs are not disabled, since the IRQ handler is force-thre

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-12 Thread Sebastian Andrzej Siewior
On 2020-08-03 18:21:45 [-0700], David Miller wrote: > From: Vladimir Oltean > > The driver calls napi_schedule_irqoff() from a context where, in RT, > > hardirqs are not disabled, since the IRQ handler is force-threaded. … > > > > Signed-off-by: Jiafei Pan > > Signed-off-by: Vladimir Oltean >

Re: [PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-03 Thread David Miller
From: Vladimir Oltean Date: Mon, 3 Aug 2020 23:10:09 +0300 > From: Jiafei Pan > > The driver calls napi_schedule_irqoff() from a context where, in RT, > hardirqs are not disabled, since the IRQ handler is force-threaded. > > In the call path of this function, __raise_softirq_irqoff() is modif

[PATCH net-next 2/2] enetc: use napi_schedule to be compatible with PREEMPT_RT

2020-08-03 Thread Vladimir Oltean
From: Jiafei Pan The driver calls napi_schedule_irqoff() from a context where, in RT, hardirqs are not disabled, since the IRQ handler is force-threaded. In the call path of this function, __raise_softirq_irqoff() is modifying its per-CPU mask of pending softirqs that must be processed, using or