Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

2015-09-15 Thread Alexei Starovoitov
On 9/15/15 9:50 PM, John Fastabend wrote: Looks like you can remove the check. I would prefer to let the stack handle this case using normal mechanisms. I had to do a bit of tracking but netif_running check equates roughly to your IFF_UP case via, ... Seem reasonable? Or did you put it there t

Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

2015-09-15 Thread John Fastabend
On 15-09-15 09:11 PM, Alexei Starovoitov wrote: > On 9/15/15 8:10 PM, John Fastabend wrote: >> Nice, I like this. But just to be sure I read this correctly this will >> only work on the ingress qdisc for now right? To get the tx side working >> will require a bit more care. > > correct. > For egre

Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

2015-09-15 Thread Alexei Starovoitov
On 9/15/15 8:10 PM, John Fastabend wrote: Nice, I like this. But just to be sure I read this correctly this will only work on the ingress qdisc for now right? To get the tx side working will require a bit more care. correct. For egress I'm waiting for Daniel to resubmit his preclassifier patch

Re: [PATCH net-next 2/2] bpf: add bpf_redirect() helper

2015-09-15 Thread John Fastabend
On 15-09-15 06:51 PM, Alexei Starovoitov wrote: > Existing bpf_clone_redirect() helper clones skb before redirecting > it to RX or TX of destination netdev. > Introduce bpf_redirect() helper that does that without cloning. > > Benchmarked with two hosts using 10G ixgbe NICs. > One host is doing li

[PATCH net-next 2/2] bpf: add bpf_redirect() helper

2015-09-15 Thread Alexei Starovoitov
Existing bpf_clone_redirect() helper clones skb before redirecting it to RX or TX of destination netdev. Introduce bpf_redirect() helper that does that without cloning. Benchmarked with two hosts using 10G ixgbe NICs. One host is doing line rate pktgen. Another host is configured as: $ tc qdisc ad