Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Thomas Graf
On 07/21/15 at 10:30am, Alexei Starovoitov wrote: > RX: > >+info->mode = IP_TUNNEL_INFO_RX; > >+info->key.tun_flags = TUNNEL_KEY; > >+info->key.tun_id = cpu_to_be64(vni >> 8); > ... > TX: > >+dst_port = info->key.tp_dst ? : vxlan->dst_port; > >+

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Alexei Starovoitov
On 7/21/15 1:43 AM, Thomas Graf wrote: This prepares the VXLAN device to be steered by the routing and other subsystems which allows to support encapsulation for a large number of tunnel endpoints and tunnel ids through a single net_device which improves the scalability. +1. looks very useful.

[PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-21 Thread Thomas Graf
Allows putting a VXLAN device into a new flow-based mode in which skbs with a ip_tunnel_info dst metadata attached will be encapsulated according to the instructions stored in there with the VXLAN device defaults taken into consideration. Similar on the receive side, if the VXLAN_F_COLLECT_METADAT

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Marcelo Ricardo Leitner
On Mon, Jul 20, 2015 at 02:15:22PM -0300, Marcelo Ricardo Leitner wrote: > On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: > > [ snip ] > > > @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) > > netif_keep_dst(dev); ---> (a) > > dev->

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Marcelo Ricardo Leitner
On Fri, Jul 17, 2015 at 02:55:33PM +0200, Thomas Graf wrote: [ snip ] > @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) > netif_keep_dst(dev); ---> (a) > dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; > > + /* If in flow based mode, keep the

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-20 Thread Thomas Graf
On 07/17/15 at 11:41am, Alexei Starovoitov wrote: > On 7/17/15 5:55 AM, Thomas Graf wrote: > >@@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) > > netif_keep_dst(dev); > > dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; > > > >+/* If in flow based mode, keep the dst inclu

Re: [PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-17 Thread Alexei Starovoitov
On 7/17/15 5:55 AM, Thomas Graf wrote: @@ -2373,6 +2470,12 @@ static void vxlan_setup(struct net_device *dev) netif_keep_dst(dev); dev->priv_flags |= IFF_LIVE_ADDR_CHANGE; + /* If in flow based mode, keep the dst including encapsulation +* instructions for vxlan_xmi

[PATCH net-next 14/22] vxlan: Flow based tunneling

2015-07-17 Thread Thomas Graf
Allows putting a VXLAN device into a new flow-based mode in which skbs with a ip_tunnel_info dst metadata attached will be encapsulated according to the instructions stored in there with the VXLAN device defaults taken into consideration. Similar on the receive side, if the VXLAN_F_COLLECT_METADAT