Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Tom Herbert
On Tue, Jul 28, 2015 at 9:11 AM, David Ahern wrote: > On 7/28/15 9:25 AM, Andy Lutomirski wrote: >> >> On Jul 27, 2015 11:33 AM, "David Ahern" wrote: >>> >>> >>> Allow tasks to have a default device index for binding sockets. If set >>> the value is passed to all AF_INET/AF_INET6 sockets when the

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 10:07 -0600, David Ahern wrote: > Problems with using network namespaces for VRFs has been discussed in > the past. e.g., > http://www.spinics.net/lists/netdev/msg298368.html Great. Are you suggesting to get rid of network namespaces ? If not, your proposal only incre

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread David Ahern
On 7/28/15 9:25 AM, Andy Lutomirski wrote: On Jul 27, 2015 11:33 AM, "David Ahern" wrote: Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. This is not intended to be a review of the concept. I

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread David Ahern
On 7/28/15 10:01 AM, Eric Dumazet wrote: On Tue, 2015-07-28 at 14:19 +0200, Hannes Frederic Sowa wrote: Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: David Ahern writes: Allow tasks to have a default device index for binding sockets. If set the value is passed to a

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric Dumazet
On Tue, 2015-07-28 at 14:19 +0200, Hannes Frederic Sowa wrote: > Hello Eric, > > On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: > > David Ahern writes: > > > > > Allow tasks to have a default device index for binding sockets. If > > > set > > > the value is passed to all AF_INET/AF

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Andy Lutomirski
On Jul 27, 2015 11:33 AM, "David Ahern" wrote: > > Allow tasks to have a default device index for binding sockets. If set > the value is passed to all AF_INET/AF_INET6 sockets when they are created. > This is not intended to be a review of the concept. I haven't thought about whether the concept

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Hannes Frederic Sowa
On Tue, 2015-07-28 at 08:54 -0500, Eric W. Biederman wrote: > Hannes Frederic Sowa writes: > > > Hello Eric, > > > > On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: > > > David Ahern writes: > > > > > > > Allow tasks to have a default device index for binding sockets. > > > > If

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Eric W. Biederman
Hannes Frederic Sowa writes: > Hello Eric, > > On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: >> David Ahern writes: >> >> > Allow tasks to have a default device index for binding sockets. If >> > set >> > the value is passed to all AF_INET/AF_INET6 sockets when they are >> > crea

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-28 Thread Hannes Frederic Sowa
Hello Eric, On Mon, 2015-07-27 at 15:33 -0500, Eric W. Biederman wrote: > David Ahern writes: > > > Allow tasks to have a default device index for binding sockets. If > > set > > the value is passed to all AF_INET/AF_INET6 sockets when they are > > created. > > > > The task setting is passed p

Re: [PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-27 Thread Eric W. Biederman
David Ahern writes: > Allow tasks to have a default device index for binding sockets. If set > the value is passed to all AF_INET/AF_INET6 sockets when they are > created. > > The task setting is passed parent to child on fork, but can be set or > changed after task creation using prctl (if task

[PATCH net-next 14/16] net: Add sk_bind_dev_if to task_struct

2015-07-27 Thread David Ahern
Allow tasks to have a default device index for binding sockets. If set the value is passed to all AF_INET/AF_INET6 sockets when they are created. The task setting is passed parent to child on fork, but can be set or changed after task creation using prctl (if task has CAP_NET_ADMIN permissions). T