On 2018/1/9 11:06, David Miller wrote:
From: "lipeng (Y)"
Date: Tue, 9 Jan 2018 10:48:04 +0800
So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add
packet statistics of netdev").
I think it is OK if you send the revert patch, which is what I
am asking for :-)
.
sure, i wi
From: "lipeng (Y)"
Date: Tue, 9 Jan 2018 10:48:04 +0800
> So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add
> packet statistics of netdev").
I think it is OK if you send the revert patch, which is what I
am asking for :-)
On 2018/1/9 9:54, David Miller wrote:
From: Jakub Kicinski
Date: Mon, 8 Jan 2018 17:50:21 -0800
Oh, I only noticed this extra misleading comment now. Unless each queue
has a netdev, I don't see how these are per-queue.
If it isn't per-queue I want this change reverted.
[patch 12/20 ] add
From: Jakub Kicinski
Date: Mon, 8 Jan 2018 17:50:21 -0800
> Oh, I only noticed this extra misleading comment now. Unless each queue
> has a netdev, I don't see how these are per-queue.
If it isn't per-queue I want this change reverted.
On Mon, 8 Jan 2018 17:46:02 -0800, Jakub Kicinski wrote:
> On Mon, 08 Jan 2018 20:39:13 -0500 (EST), David Miller wrote:
> > From: Jakub Kicinski
> > Date: Mon, 8 Jan 2018 12:04:31 -0800
> >
> > > Ugh, I so didn't review this in time :( I think there is a consensus
> > > that we should avoid d
On Mon, 08 Jan 2018 20:39:13 -0500 (EST), David Miller wrote:
> From: Jakub Kicinski
> Date: Mon, 8 Jan 2018 12:04:31 -0800
>
> > Ugh, I so didn't review this in time :( I think there is a consensus
> > that we should avoid duplicating standard stats in ethtool. Especially
> > those old ones.
From: Jakub Kicinski
Date: Mon, 8 Jan 2018 12:04:31 -0800
> Ugh, I so didn't review this in time :( I think there is a consensus
> that we should avoid duplicating standard stats in ethtool. Especially
> those old ones. Like "collisions", I assume this is a modern NIC, are
> collisions still a
On Fri, 5 Jan 2018 18:18:16 +0800, Peng Li wrote:
> +static const struct hns3_stats hns3_netdev_stats[] = {
> + /* Rx per-queue statistics */
> + HNS3_NETDEV_STAT("rx_packets", rx_packets),
> + HNS3_NETDEV_STAT("tx_packets", tx_packets),
> + HNS3_NETDEV_STAT("rx_bytes", rx_bytes),
>
From: Jian Shen
Add packet statistics of netdev for ethtool -S, in
order to show the statistics data for current net
device.
Remove update_stats() calling because it has been
completed in hns3_get_netdev_stats().
Signed-off-by: Jian Shen
Signed-off-by: Peng Li
---
drivers/net/ethernet/hisili
