Re: [PATCH net-next 12/12] net: sched: flower: set unlocked flag for flower proto ops

2019-02-20 Thread Cong Wang
On Tue, Feb 19, 2019 at 2:15 AM Vlad Buslov wrote: > > > On Mon 18 Feb 2019 at 19:27, Cong Wang wrote: > > On Wed, Feb 13, 2019 at 11:47 PM Vlad Buslov wrote: > >> > >> Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that its > >> ops callbacks don't require caller to hold rtnl

Re: [PATCH net-next 12/12] net: sched: flower: set unlocked flag for flower proto ops

2019-02-19 Thread Vlad Buslov
On Mon 18 Feb 2019 at 19:27, Cong Wang wrote: > On Wed, Feb 13, 2019 at 11:47 PM Vlad Buslov wrote: >> >> Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that its >> ops callbacks don't require caller to hold rtnl lock. > > So, if this means RTNL is gone for all cls_flower cha

Re: [PATCH net-next 12/12] net: sched: flower: set unlocked flag for flower proto ops

2019-02-18 Thread Cong Wang
On Wed, Feb 13, 2019 at 11:47 PM Vlad Buslov wrote: > > Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that its > ops callbacks don't require caller to hold rtnl lock. So, if this means RTNL is gone for all cls_flower changes, why do I still see rtnl_lock() in cls_flower.c afte

[PATCH net-next 12/12] net: sched: flower: set unlocked flag for flower proto ops

2019-02-13 Thread Vlad Buslov
Set TCF_PROTO_OPS_DOIT_UNLOCKED for flower classifier to indicate that its ops callbacks don't require caller to hold rtnl lock. Signed-off-by: Vlad Buslov Acked-by: Jiri Pirko --- net/sched/cls_flower.c | 1 + 1 file changed, 1 insertion(+) diff --git a/net/sched/cls_flower.c b/net/sched/cls_