> I know this looks boring, I do not particularly enjoy it myself, but I
> think this is also important. I don't mind fixing the poking function as
> well in the near future.
It would be great if you do. It could be as simple as using
phy_ethtool_get_eee() and phy_ethtool_set_eee().
Andrew
Hi David,
David Miller writes:
> However, in this particular case, this issue was brought to Vivien's
> attention multiple times in the past.
>
> And I think the direct PHY poking issue is much more important than
> these seemingly endless reorganizations of the driver that Vivien is
> doing.
>
From: Florian Fainelli
Date: Tue, 18 Jul 2017 09:01:01 -0700
> On 07/17/2017 02:10 PM, David Miller wrote:
>> From: Andrew Lunn
>> Date: Mon, 17 Jul 2017 23:04:05 +0200
>>
>>> On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote:
From: Vivien Didelot
Date: Mon, 17 Jul 2017 15
On 07/17/2017 02:10 PM, David Miller wrote:
> From: Andrew Lunn
> Date: Mon, 17 Jul 2017 23:04:05 +0200
>
>> On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote:
>>> From: Vivien Didelot
>>> Date: Mon, 17 Jul 2017 15:32:52 -0400
>>>
Hi Andrew,
Andrew Lunn writes:
>>
From: Andrew Lunn
Date: Mon, 17 Jul 2017 23:04:05 +0200
> On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote:
>> From: Vivien Didelot
>> Date: Mon, 17 Jul 2017 15:32:52 -0400
>>
>> > Hi Andrew,
>> >
>> > Andrew Lunn writes:
>> >
>> >> I never liked this. I think it is architectural
On Mon, Jul 17, 2017 at 01:45:49PM -0700, David Miller wrote:
> From: Vivien Didelot
> Date: Mon, 17 Jul 2017 15:32:52 -0400
>
> > Hi Andrew,
> >
> > Andrew Lunn writes:
> >
> >> I never liked this. I think it is architecturally wrong for the switch
> >> to be poking around in the PHY. It shou
From: Vivien Didelot
Date: Mon, 17 Jul 2017 15:32:52 -0400
> Hi Andrew,
>
> Andrew Lunn writes:
>
>> I never liked this. I think it is architecturally wrong for the switch
>> to be poking around in the PHY. It should ask the PHY driver. This is
>> especially true for external PHYs which might
Hi Andrew,
Andrew Lunn writes:
> I never liked this. I think it is architecturally wrong for the switch
> to be poking around in the PHY. It should ask the PHY driver. This is
> especially true for external PHYs which might not be a Marvell PHY.
I share the same concern. However this patch is j
> diff --git a/drivers/net/dsa/mv88e6xxx/phy.c b/drivers/net/dsa/mv88e6xxx/phy.c
> index 436668bd50dc..317ae89cfa68 100644
> --- a/drivers/net/dsa/mv88e6xxx/phy.c
> +++ b/drivers/net/dsa/mv88e6xxx/phy.c
> @@ -246,3 +246,99 @@ int mv88e6xxx_phy_setup(struct mv88e6xxx_chip *chip)
> {
> return
The 88E6352 family supports Energy Detect and has one bit for Sense and
one bit for periodically transmit NLP (Energy Detect+TM). The 88E6390
family adds another bit to distinguish Auto or SW wake-up. Chips
supporting EEE all have an EEE Enabled bit in the Port Status Register.
This patch adds new
The 88E6352 family supports Energy Detect and has one bit for Sense and
one bit for periodically transmit NLP (Energy Detect+TM). The 88E6390
family adds another bit to distinguish Auto or SW wake-up. Chips
supporting EEE all have an EEE Enabled bit in the Port Status Register.
This patch adds new
11 matches
Mail list logo
