Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-06 Thread Jakub Kicinski
On Wed, 6 May 2020 09:56:41 +0200 Julian Wiedmann wrote: > On 05.05.20 23:28, Jakub Kicinski wrote: > > On Tue, 5 May 2020 21:57:43 +0200 Julian Wiedmann wrote: > >>> This is the comment from the uAPI header: > >>> > >>> /* The reset() operation must clear the flags for the components which > >>>

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-06 Thread Julian Wiedmann
On 05.05.20 23:28, Jakub Kicinski wrote: > On Tue, 5 May 2020 21:57:43 +0200 Julian Wiedmann wrote: >>> This is the comment from the uAPI header: >>> >>> /* The reset() operation must clear the flags for the components which >>> * were actually reset. On successful return, the flags indicate the

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-05 Thread Jakub Kicinski
On Tue, 5 May 2020 21:57:43 +0200 Julian Wiedmann wrote: > > This is the comment from the uAPI header: > > > > /* The reset() operation must clear the flags for the components which > > * were actually reset. On successful return, the flags indicate the > > * components which were not reset, ei

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-05 Thread Edwin Peer
On Tue, May 5, 2020 at 12:57 PM Julian Wiedmann wrote: > It's a virtual device, _none_ of them make much sense?! Why not introduce a new reset bit that captures the semantics of whatever qeth_schedule_recovery does? Regards, Edwin Peer

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-05 Thread Julian Wiedmann
On 05.05.20 20:29, Jakub Kicinski wrote: > On Tue, 5 May 2020 20:23:31 +0200 Julian Wiedmann wrote: >> On 05.05.20 19:21, Jakub Kicinski wrote: >>> On Tue, 5 May 2020 18:25:58 +0200 Julian Wiedmann wrote: Implement the .reset callback. Only a full reset is supported. Signed-off-by

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-05 Thread Jakub Kicinski
On Tue, 5 May 2020 20:23:31 +0200 Julian Wiedmann wrote: > On 05.05.20 19:21, Jakub Kicinski wrote: > > On Tue, 5 May 2020 18:25:58 +0200 Julian Wiedmann wrote: > >> Implement the .reset callback. Only a full reset is supported. > >> > >> Signed-off-by: Julian Wiedmann > >> Reviewed-by: Alexand

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-05 Thread Julian Wiedmann
On 05.05.20 19:21, Jakub Kicinski wrote: > On Tue, 5 May 2020 18:25:58 +0200 Julian Wiedmann wrote: >> Implement the .reset callback. Only a full reset is supported. >> >> Signed-off-by: Julian Wiedmann >> Reviewed-by: Alexandra Winter >> --- >> drivers/s390/net/qeth_ethtool.c | 16

Re: [PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-05 Thread Jakub Kicinski
On Tue, 5 May 2020 18:25:58 +0200 Julian Wiedmann wrote: > Implement the .reset callback. Only a full reset is supported. > > Signed-off-by: Julian Wiedmann > Reviewed-by: Alexandra Winter > --- > drivers/s390/net/qeth_ethtool.c | 16 > 1 file changed, 16 insertions(+) > > di

[PATCH net-next 10/11] s390/qeth: allow reset via ethtool

2020-05-05 Thread Julian Wiedmann
Implement the .reset callback. Only a full reset is supported. Signed-off-by: Julian Wiedmann Reviewed-by: Alexandra Winter --- drivers/s390/net/qeth_ethtool.c | 16 1 file changed, 16 insertions(+) diff --git a/drivers/s390/net/qeth_ethtool.c b/drivers/s390/net/qeth_ethtool.c