> Thanks for the other comments. I'll sort out the issues before preparing an
> update but it will take a few weeks to re-test the driver and prepare a new
> patch.
Given the complexity of these patches, you can expect to go around the
cycle a few times. So do testing, but also assume you are goin
Apologies for taking a while to respond.
> -Original Message-
> From: Jesse Brandeburg
> Sent: 04 February 2021 20:43
>
> NB: I thought I'd have a close look at this since I thought I
> understand NAPI pretty well, but using NAPI to transmit frames as well
> as with a usb device has got
Apologies for taking a while to reply.
> This patch is big. Given your description, it sounds like it can be
> split up. That will make reviewing a lot easier.
The patch changes the way the driver works in a fundamental way so finding
ways to split out the modifications into self-contained parts
NB: I thought I'd have a close look at this since I thought I
understand NAPI pretty well, but using NAPI to transmit frames as well
as with a usb device has got me pretty confused. Also, I suspect that
you didn't try compiling this against the net-next kernel.
I'm stopping my review only partiall
Improve driver throughput and reduce CPU overhead by using the NAPI
interface for processing Rx packets and scheduling Tx and Rx URBs.
Provide statically-allocated URB and buffer pool for both Tx and Rx
packets to give greater control over resource allocation.
Remove modification of hard_header_l
