Re: [PATCH net-next 1/8] net: dsa: mv88e6xxx: Abstract PTP operations

2018-07-17 Thread David Miller
From: Andrew Lunn Date: Tue, 17 Jul 2018 23:48:53 +0200 > @@ -319,6 +337,8 @@ int mv88e6xxx_ptp_setup(struct mv88e6xxx_chip *chip) > { > int i; > > + const struct mv88e6xxx_ptp_ops *ptp_ops = chip->info->ops->ptp_ops; > + Please keep the local variables together here. Otherwise, th

[PATCH net-next 1/8] net: dsa: mv88e6xxx: Abstract PTP operations

2018-07-17 Thread Andrew Lunn
The mv88e6165 family supports PTP, but its registers use a different layout to the currently supported devices. Abstract accessing the PTP registers into a set of ops, so making space for a second implementation. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx/chip.c | 11 +++ drive