Re: [PATCH net-next 1/8] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-04-14 Thread David Miller
From: Florian Fainelli Date: Thu, 14 Apr 2016 14:26:39 -0700 > On 14/04/16 13:22, Vivien Didelot wrote: >> Hi Andrew, >> >> Andrew Lunn writes: >> >>> Export all the functions so that we can later turn the module into a >>> library module. >>> >>> Signed-off-by: Andrew Lunn >> >> Sorry but I

Re: [PATCH net-next 1/8] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-04-14 Thread Andrew Lunn
> I believe this is currently the case for most of what is being done by > mv88e6xxx.c, Andrew's patches are not making things worse. Hi Florian That was my aim. I did the minimum restructuring needed to make these DSA drivers classical Linux drivers. Nothing i've done would prevent them being me

Re: [PATCH net-next 1/8] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-04-14 Thread Andrew Lunn
Hi Vivien > I'm working on a few patches right away to factorize this and lighten up > that part from your current refactoring of DSA. Please take a look at the full series of 40 patches, before deciding what you want to clean up. It is too many to post at once, so i'm breaking them up into chunk

Re: [PATCH net-next 1/8] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-04-14 Thread Florian Fainelli
On 14/04/16 13:22, Vivien Didelot wrote: > Hi Andrew, > > Andrew Lunn writes: > >> Export all the functions so that we can later turn the module into a >> library module. >> >> Signed-off-by: Andrew Lunn > > Sorry but I don't like this. We don't want one module per 88E6xxx switch > model. We n

Re: [PATCH net-next 1/8] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-04-14 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: > Export all the functions so that we can later turn the module into a > library module. > > Signed-off-by: Andrew Lunn Sorry but I don't like this. We don't want one module per 88E6xxx switch model. We need one driver supporting them all, like any other driver.

[PATCH net-next 1/8] dsa: mv88e6xxx: Prepare for turning this into a library module

2016-04-13 Thread Andrew Lunn
Export all the functions so that we can later turn the module into a library module. Signed-off-by: Andrew Lunn --- drivers/net/dsa/mv88e6xxx.c | 44 1 file changed, 44 insertions(+) diff --git a/drivers/net/dsa/mv88e6xxx.c b/drivers/net/dsa/mv88e6xx