Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2018-01-03 Thread Russell King - ARM Linux
On Wed, Jan 03, 2018 at 04:08:30PM +0100, Andrew Lunn wrote: > > > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > > >>> index 4f8423a948d5..70459a28f3a1 100644 > > > >>> --- a/include/linux/phy/phy.h > > > >>> +++ b/include/linux/phy/phy.h > > > >>> @@ -28,6 +28,7 @@ enum ph

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2018-01-03 Thread Andrew Lunn
> > >>> diff --git a/include/linux/phy/phy.h b/include/linux/phy/phy.h > > >>> index 4f8423a948d5..70459a28f3a1 100644 > > >>> --- a/include/linux/phy/phy.h > > >>> +++ b/include/linux/phy/phy.h > > >>> @@ -28,6 +28,7 @@ enum phy_mode { > > >>> PHY_MODE_USB_DEVICE, > > >>> PHY_MODE_

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2018-01-03 Thread Antoine Tenart
Hi Florian, On Thu, Dec 28, 2017 at 06:16:51AM -0800, Florian Fainelli wrote: > On 12/28/2017 02:06 AM, Antoine Tenart wrote: > > On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: > >> On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > >>> This patch adds one more generic

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-28 Thread Antoine Tenart
Hi Florian, On Thu, Dec 28, 2017 at 06:16:51AM -0800, Florian Fainelli wrote: > > And since you are respinning, please make sure you update phy_modes() in > the same header file as well as > Documentation/devicetree/bindings/net/ethernet.txt with the newly added > PHY interface mode. You're righ

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-28 Thread Florian Fainelli
On 12/28/2017 02:06 AM, Antoine Tenart wrote: > Hi Andrew, > > On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: >> On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: >>> This patch adds one more generic PHY mode to the phy_mode enum, to allow >>> configuring generic PHYs

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-28 Thread Antoine Tenart
Hi Andrew, On Thu, Dec 28, 2017 at 08:20:53AM +0100, Andrew Lunn wrote: > On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > > This patch adds one more generic PHY mode to the phy_mode enum, to allow > > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > > callb

Re: [PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-27 Thread Andrew Lunn
On Wed, Dec 27, 2017 at 11:14:41PM +0100, Antoine Tenart wrote: > This patch adds one more generic PHY mode to the phy_mode enum, to allow > configuring generic PHYs to the 2.5G SGMII mode by using the set_mode > callback. > > Signed-off-by: Antoine Tenart > --- > include/linux/phy/phy.h | 1 + >

[PATCH net-next 1/6] phy: add 2.5G SGMII mode to the phy_mode enum

2017-12-27 Thread Antoine Tenart
This patch adds one more generic PHY mode to the phy_mode enum, to allow configuring generic PHYs to the 2.5G SGMII mode by using the set_mode callback. Signed-off-by: Antoine Tenart --- include/linux/phy/phy.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/linux/phy/phy.h b/include