Re: [PATCH net-next 1/6] net: dsa: use a single switch statement for port setup

2019-08-19 Thread Vivien Didelot
Hi Florian, On Mon, 19 Aug 2019 10:14:24 -0700, Florian Fainelli wrote: > On 8/18/19 10:35 AM, Vivien Didelot wrote: > > It is currently difficult to read the different steps involved in the > > setup and teardown of ports in the DSA code. Keep it simple with a > > single switch statement for ea

Re: [PATCH net-next 1/6] net: dsa: use a single switch statement for port setup

2019-08-19 Thread Florian Fainelli
On 8/18/19 10:35 AM, Vivien Didelot wrote: > It is currently difficult to read the different steps involved in the > setup and teardown of ports in the DSA code. Keep it simple with a > single switch statement for each port type: UNUSED, CPU, DSA, or USER. > > Also no need to call devlink_port_unr

[PATCH net-next 1/6] net: dsa: use a single switch statement for port setup

2019-08-18 Thread Vivien Didelot
It is currently difficult to read the different steps involved in the setup and teardown of ports in the DSA code. Keep it simple with a single switch statement for each port type: UNUSED, CPU, DSA, or USER. Also no need to call devlink_port_unregister from within dsa_port_setup as this step is in