Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Christoph Paasch
On 17/12/18 - 14:01:41, Eric Dumazet wrote: > On Mon, Dec 17, 2018 at 1:57 PM Christoph Paasch wrote: > > > > On 17/12/18 - 08:04:08, Eric Dumazet wrote: > > > On Fri, Dec 14, 2018 at 2:40 PM Christoph Paasch > > > wrote: > > > > > > > > > > ... > > > > > > > int tcp_fastopen_reset_cipher(struc

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Eric Dumazet
On Mon, Dec 17, 2018 at 1:57 PM Christoph Paasch wrote: > > On 17/12/18 - 08:04:08, Eric Dumazet wrote: > > On Fri, Dec 14, 2018 at 2:40 PM Christoph Paasch wrote: > > > > > > > ... > > > > > int tcp_fastopen_reset_cipher(struct net *net, struct sock *sk, > > > void

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Christoph Paasch
On 17/12/18 - 08:04:08, Eric Dumazet wrote: > On Fri, Dec 14, 2018 at 2:40 PM Christoph Paasch wrote: > > > > ... > > > int tcp_fastopen_reset_cipher(struct net *net, struct sock *sk, > > void *key, unsigned int len) > > { > > @@ -96,13 +131,22 @@ error:

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Eric Dumazet
On 12/17/2018 07:49 AM, Christoph Paasch wrote: > It gets called from tcp_fastopen_destroy_cipher() though (to destroy the > socket's TFO-keys when the socket gets closed). There it has to destroy the > whole list. > > Same when going through exit_batch for the namespace. > > > We could of c

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Eric Dumazet
On Fri, Dec 14, 2018 at 2:40 PM Christoph Paasch wrote: > ... > int tcp_fastopen_reset_cipher(struct net *net, struct sock *sk, > void *key, unsigned int len) > { > @@ -96,13 +131,22 @@ error: kfree(ctx); > spin_lock(&net->ipv4.tcp_fastopen_ctx

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-17 Thread Christoph Paasch
On 16/12/18 - 22:31:41, Eric Dumazet wrote: > > > On 12/14/2018 02:40 PM, Christoph Paasch wrote: > > Instead of having a single TFO-context, we now have a list of > > tcp_fastopen_context, bounded by TCP_FASTOPEN_CTXT_LEN (set to 2). > > > > This enables us to do a rolling TFO-key update that a

Re: [PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-16 Thread Eric Dumazet
On 12/14/2018 02:40 PM, Christoph Paasch wrote: > Instead of having a single TFO-context, we now have a list of > tcp_fastopen_context, bounded by TCP_FASTOPEN_CTXT_LEN (set to 2). > > This enables us to do a rolling TFO-key update that allows the server to > accept old cookies and at the same

[PATCH net-next 1/5] tcp: Create list of TFO-contexts

2018-12-14 Thread Christoph Paasch
Instead of having a single TFO-context, we now have a list of tcp_fastopen_context, bounded by TCP_FASTOPEN_CTXT_LEN (set to 2). This enables us to do a rolling TFO-key update that allows the server to accept old cookies and at the same time announce new ones to the client (see follow-up patch).