Re: [PATCH net-next 1/5] net: mvpp2: use the same buffer pool for all ports

2018-03-05 Thread Antoine Tenart
Hi Thomas, On Mon, Mar 05, 2018 at 01:41:48PM +0100, Thomas Petazzoni wrote: > On Mon, 5 Mar 2018 11:48:13 +0100, Antoine Tenart wrote: > > > > > +static void mvpp2_setup_bm_pool(void) > > > > +{ > > > > + /* Short pool */ > > > > + mvpp2_pools[MVPP2_BM_SHORT].buf_num = MVPP2_BM_SHOR

Re: [PATCH net-next 1/5] net: mvpp2: use the same buffer pool for all ports

2018-03-05 Thread Thomas Petazzoni
Hello, On Mon, 5 Mar 2018 11:48:13 +0100, Antoine Tenart wrote: > > > +static void mvpp2_setup_bm_pool(void) > > > +{ > > > + /* Short pool */ > > > + mvpp2_pools[MVPP2_BM_SHORT].buf_num = MVPP2_BM_SHORT_BUF_NUM; > > > + mvpp2_pools[MVPP2_BM_SHORT].pkt_size = MVPP2_BM_SHORT_PKT_SIZE; > > > + > >

Re: [PATCH net-next 1/5] net: mvpp2: use the same buffer pool for all ports

2018-03-05 Thread Antoine Tenart
Hi Thomas, On Fri, Mar 02, 2018 at 05:01:59PM +0100, Thomas Petazzoni wrote: > On Fri, 2 Mar 2018 16:40:40 +0100, Antoine Tenart wrote: > > +static struct { > > + int pkt_size; > > + int buf_num; > > +} mvpp2_pools[MVPP2_BM_POOLS_NUM]; > > Any reason for not doing: > > } mvpp2_pools[MVPP2_B

RE: [PATCH net-next 1/5] net: mvpp2: use the same buffer pool for all ports

2018-03-03 Thread Stefan Chulski
> Hello, > > On Fri, 2 Mar 2018 16:40:40 +0100, Antoine Tenart wrote: > > +static struct { > > + int pkt_size; > > + int buf_num; > > +} mvpp2_pools[MVPP2_BM_POOLS_NUM]; > > Any reason for not doing: > > } mvpp2_pools[MVPP2_BM_POOLS_NUM] = { > [MVPP2_BM_SHORT] = { > .pkt

Re: [PATCH net-next 1/5] net: mvpp2: use the same buffer pool for all ports

2018-03-02 Thread Thomas Petazzoni
Hello, On Fri, 2 Mar 2018 16:40:40 +0100, Antoine Tenart wrote: > +static struct { > + int pkt_size; > + int buf_num; > +} mvpp2_pools[MVPP2_BM_POOLS_NUM]; Any reason for not doing: } mvpp2_pools[MVPP2_BM_POOLS_NUM] = { [MVPP2_BM_SHORT] = { .pkt_size = MVPP2_BM_S

[PATCH net-next 1/5] net: mvpp2: use the same buffer pool for all ports

2018-03-02 Thread Antoine Tenart
From: Stefan Chulski This patch configures the buffer manager long pool for all ports part of the same CP. Long pool separation between ports is redundant since there are no performance improvement when different pools are used. Signed-off-by: Stefan Chulski [Antoine: cosmetic cleanup, commit m