Re: [PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page

2018-09-12 Thread Tushar Dave
On 09/12/2018 09:51 AM, John Fastabend wrote: On 09/12/2018 09:21 AM, Tushar Dave wrote: On 09/11/2018 12:38 PM, Tushar Dave wrote: Helper bpg_msg_pull_data() can allocate multiple pages while linearizing multiple scatterlist elements into one shared page. However, if the shared page has s

Re: [PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page

2018-09-12 Thread John Fastabend
On 09/12/2018 09:21 AM, Tushar Dave wrote: > > > On 09/11/2018 12:38 PM, Tushar Dave wrote: >> Helper bpg_msg_pull_data() can allocate multiple pages while >> linearizing multiple scatterlist elements into one shared page. >> However, if the shared page has size > PAGE_SIZE, using >> copy_page_to

Re: [PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page

2018-09-12 Thread Tushar Dave
On 09/11/2018 12:38 PM, Tushar Dave wrote: Helper bpg_msg_pull_data() can allocate multiple pages while linearizing multiple scatterlist elements into one shared page. However, if the shared page has size > PAGE_SIZE, using copy_page_to_iter() causes below warning. e.g. [ 6367.019832] WARNING

[PATCH net-next 1/5] bpf: use __GFP_COMP while allocating page

2018-09-11 Thread Tushar Dave
Helper bpg_msg_pull_data() can allocate multiple pages while linearizing multiple scatterlist elements into one shared page. However, if the shared page has size > PAGE_SIZE, using copy_page_to_iter() causes below warning. e.g. [ 6367.019832] WARNING: CPU: 2 PID: 7410 at lib/iov_iter.c:825 page_co