Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Eric Dumazet
On Thu, 2015-10-08 at 13:53 -0700, Tom Herbert wrote: > If the incoming CPU is set for a connected UDP via > sk_incoming_cpu_update, wouldn't this check subsequently _only_ allow > packets for that socket to come from the same CPU? > Hmm, I thought the SO_REUSEPORT path would be taken only for n

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Tom Herbert
On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: > SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command > to fetch incoming cpu handling a particular TCP flow after accept() > > This commits adds setsockopt() support and extends SO_REUSEPORT selection > logic : If a TCP li

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Tom Herbert
On Thu, Oct 8, 2015 at 10:00 AM, Eric Dumazet wrote: > On Thu, 2015-10-08 at 09:44 -0700, Tom Herbert wrote: > >> I see. We are not using SO_INCOMING_CPU_MASK as a defense against >> DDOS. It's used ensure affinity in application connection processing >> between CPUs. For instance, if we have two

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Eric Dumazet
On Thu, 2015-10-08 at 09:44 -0700, Tom Herbert wrote: > I see. We are not using SO_INCOMING_CPU_MASK as a defense against > DDOS. It's used ensure affinity in application connection processing > between CPUs. For instance, if we have two NUMA nodes we can start two > instances of the application b

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Tom Herbert
On Thu, Oct 8, 2015 at 9:29 AM, Eric Dumazet wrote: > On Thu, 2015-10-08 at 09:03 -0700, Tom Herbert wrote: >> On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: >> > SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command >> > to fetch incoming cpu handling a particular TCP f

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Eric Dumazet
On Thu, 2015-10-08 at 09:29 -0700, Eric Dumazet wrote: > For optimal behavior against DDOS, you need one TCP _listener_ per RX > queue on the NIC. I will reword the changelog to make this clear, and fix the htmldocs warning reported by kbuild in V2. -- To unsubscribe from this list: send the li

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Eric Dumazet
On Thu, 2015-10-08 at 09:03 -0700, Tom Herbert wrote: > On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: > > SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command > > to fetch incoming cpu handling a particular TCP flow after accept() > > > > This commits adds setsockopt()

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread kbuild test robot
Hi Eric, [auto build test WARNING on net-next/master -- if it's inappropriate base, please ignore] reproduce: make htmldocs All warnings (new ones prefixed by >>): include/linux/skbuff.h:833: warning: No description found for parameter 'sk' >> include/net/sock.h:442: warning: Excess struct/

Re: [PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Tom Herbert
On Thu, Oct 8, 2015 at 8:37 AM, Eric Dumazet wrote: > SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command > to fetch incoming cpu handling a particular TCP flow after accept() > > This commits adds setsockopt() support and extends SO_REUSEPORT selection > logic : If a TCP li

[PATCH net-next 1/4] net: SO_INCOMING_CPU setsockopt() support

2015-10-08 Thread Eric Dumazet
SO_INCOMING_CPU as added in commit 2c8c56e15df3 was a getsockopt() command to fetch incoming cpu handling a particular TCP flow after accept() This commits adds setsockopt() support and extends SO_REUSEPORT selection logic : If a TCP listener or UDP socket has this option set, a packet is delivere