Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-11 Thread Dinesh Dutt
Yes, this is what I liked about the 2 flag solution too compared to the original. Dinesh On Thu, Jun 11, 2015 at 7:50 AM, Alexander Duyck wrote: > > > On 06/11/2015 04:23 AM, Andy Gospodarek wrote: >> >> On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote: >>> >>> On Wed, Jun 10, 2015

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-11 Thread Scott Feldman
On Thu, Jun 11, 2015 at 7:50 AM, Alexander Duyck wrote: > > > On 06/11/2015 04:23 AM, Andy Gospodarek wrote: >> >> On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote: >>> >>> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek >>> wrote: Add a fib flag called RTNH_F_LINKDOWN to

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-11 Thread Alexander Duyck
On 06/11/2015 04:23 AM, Andy Gospodarek wrote: On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote: On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek wrote: Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are reachable via an interface where carrier is off. No actio

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-11 Thread Scott Feldman
On Thu, Jun 11, 2015 at 4:23 AM, Andy Gospodarek wrote: > On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote: >> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek >> wrote: >> > Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are >> > reachable via an interface where car

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-11 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 11:07:28PM -0700, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek > wrote: > > Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are > > reachable via an interface where carrier is off. No action is taken, > > but additional flags are

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek wrote: > Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are > reachable via an interface where carrier is off. No action is taken, > but additional flags are passed to userspace to indicate carrier status. Andy, it seems now RTNH_

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 8:28 PM, Andy Gospodarek wrote: > On Wed, Jun 10, 2015 at 07:53:59PM -0700, Scott Feldman wrote: >> On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek >> wrote: >> >> > @@ -1129,7 +1142,15 @@ int fib_sync_down_dev(struct net_device *dev, int >> > force) >> >

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Andy Gospodarek
On Wed, Jun 10, 2015 at 07:53:59PM -0700, Scott Feldman wrote: > On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek > wrote: > > > @@ -1129,7 +1142,15 @@ int fib_sync_down_dev(struct net_device *dev, int > > force) > > dead++; > > else if (ne

Re: [PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Scott Feldman
On Wed, Jun 10, 2015 at 7:37 PM, Andy Gospodarek wrote: > @@ -1129,7 +1142,15 @@ int fib_sync_down_dev(struct net_device *dev, int > force) > dead++; > else if (nexthop_nh->nh_dev == dev && > nexthop_nh->nh_

[PATCH net-next 1/3 v3] net: track link-status of ipv4 nexthops

2015-06-10 Thread Andy Gospodarek
Add a fib flag called RTNH_F_LINKDOWN to any ipv4 nexthops that are reachable via an interface where carrier is off. No action is taken, but additional flags are passed to userspace to indicate carrier status. This also includes a cleanup to fib_disable_ip to more clearly indicate what event made