Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Daniel Borkmann
On 07/13/2016 06:40 PM, Peter Zijlstra wrote: On Wed, Jul 13, 2016 at 04:08:55PM +0200, Daniel Borkmann wrote: On 07/13/2016 03:42 PM, Peter Zijlstra wrote: Ok so the nonlinear thing was it doing _two_ copies, one the regular __output_copy() on raw->data and second the optional fragment thingy

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Peter Zijlstra
On Wed, Jul 13, 2016 at 04:08:55PM +0200, Daniel Borkmann wrote: > Hi Peter, > > On 07/13/2016 03:42 PM, Peter Zijlstra wrote: > > > >Ok so the nonlinear thing was it doing _two_ copies, one the regular > >__output_copy() on raw->data and second the optional fragment thingy > >using __output_custo

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Daniel Borkmann
Hi Peter, On 07/13/2016 03:42 PM, Peter Zijlstra wrote: Ok so the nonlinear thing was it doing _two_ copies, one the regular __output_copy() on raw->data and second the optional fragment thingy using __output_custom(). Would something like this work instead? It does the nonlinear thing and th

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Peter Zijlstra
Ok so the nonlinear thing was it doing _two_ copies, one the regular __output_copy() on raw->data and second the optional fragment thingy using __output_custom(). Would something like this work instead? It does the nonlinear thing and the custom copy function thing but allows more than 2 fragmen

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Daniel Borkmann
On 07/13/2016 02:10 PM, Peter Zijlstra wrote: On Wed, Jul 13, 2016 at 11:24:13AM +0200, Daniel Borkmann wrote: On 07/13/2016 09:52 AM, Peter Zijlstra wrote: On Wed, Jul 13, 2016 at 12:36:17AM +0200, Daniel Borkmann wrote: This patch adds support for non-linear data on raw records. It means tha

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Peter Zijlstra
On Wed, Jul 13, 2016 at 11:24:13AM +0200, Daniel Borkmann wrote: > Hi Peter, > > On 07/13/2016 09:52 AM, Peter Zijlstra wrote: > >On Wed, Jul 13, 2016 at 12:36:17AM +0200, Daniel Borkmann wrote: > >>This patch adds support for non-linear data on raw records. It means > >>that for such data, the ne

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Daniel Borkmann
Hi Peter, On 07/13/2016 09:52 AM, Peter Zijlstra wrote: On Wed, Jul 13, 2016 at 12:36:17AM +0200, Daniel Borkmann wrote: This patch adds support for non-linear data on raw records. It means that for such data, the newly introduced __output_custom() helper will be used instead of __output_copy()

Re: [PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-13 Thread Peter Zijlstra
On Wed, Jul 13, 2016 at 12:36:17AM +0200, Daniel Borkmann wrote: > This patch adds support for non-linear data on raw records. It means > that for such data, the newly introduced __output_custom() helper will > be used instead of __output_copy(). __output_custom() will invoke > whatever custom call

[PATCH net-next 1/3] perf, events: add non-linear data support for raw records

2016-07-12 Thread Daniel Borkmann
This patch adds support for non-linear data on raw records. It means that for such data, the newly introduced __output_custom() helper will be used instead of __output_copy(). __output_custom() will invoke whatever custom callback is passed in via struct perf_raw_record_frag to extract the data int