Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-20 Thread Petr Machata
David Ahern writes: > On 1/19/21 1:55 PM, Jakub Kicinski wrote: >>> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c >>> index e53e43aef785..d5d88f7c5c11 100644 >>> --- a/net/ipv4/nexthop.c >>> +++ b/net/ipv4/nexthop.c >>> @@ -36,6 +36,10 @@ static const struct nla_policy rtm_nh_policy[NHA_

Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-19 Thread David Ahern
On 1/19/21 1:55 PM, Jakub Kicinski wrote: >> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c >> index e53e43aef785..d5d88f7c5c11 100644 >> --- a/net/ipv4/nexthop.c >> +++ b/net/ipv4/nexthop.c >> @@ -36,6 +36,10 @@ static const struct nla_policy rtm_nh_policy[NHA_MAX + 1] >> = { >> [NHA_F

Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-19 Thread Jakub Kicinski
On Tue, 19 Jan 2021 19:28:40 -0700 David Ahern wrote: > On 1/19/21 1:55 PM, Jakub Kicinski wrote: > >> diff --git a/net/ipv4/nexthop.c b/net/ipv4/nexthop.c > >> index e53e43aef785..d5d88f7c5c11 100644 > >> --- a/net/ipv4/nexthop.c > >> +++ b/net/ipv4/nexthop.c > >> @@ -36,6 +36,10 @@ static const s

Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-19 Thread Jakub Kicinski
On Mon, 18 Jan 2021 15:05:23 +0100 Petr Machata wrote: > This function uses the global nexthop policy only to then bounce all > arguments except for NHA_ID. Instead, just create a new policy that > only includes the one allowed attribute. > > Signed-off-by: Petr Machata > Reviewed-by: Ido Schimme

Re: [PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-18 Thread David Ahern
On 1/18/21 7:05 AM, Petr Machata wrote: > This function uses the global nexthop policy only to then bounce all > arguments except for NHA_ID. Instead, just create a new policy that > only includes the one allowed attribute. > > Signed-off-by: Petr Machata > Reviewed-by: Ido Schimmel > --- > net

[PATCH net-next 1/3] nexthop: Use a dedicated policy for nh_valid_get_del_req()

2021-01-18 Thread Petr Machata
This function uses the global nexthop policy only to then bounce all arguments except for NHA_ID. Instead, just create a new policy that only includes the one allowed attribute. Signed-off-by: Petr Machata Reviewed-by: Ido Schimmel --- net/ipv4/nexthop.c | 21 ++--- 1 file chang