Re: [PATCH net-next 1/3] net: dsa: mt7530: Convert to PHYLINK API

2019-08-01 Thread David Miller
From: René van Dorst Date: Thu, 01 Aug 2019 17:21:04 + > Quoting Russell King - ARM Linux admin : > >> Hi, >> >> Just a couple of minor points. >> >> On Wed, Jul 24, 2019 at 09:25:47PM +0200, René van Dorst wrote: > > > >>> + >>> +static void mt7530_phylink_validate(struct dsa_switch *ds,

Re: [PATCH net-next 1/3] net: dsa: mt7530: Convert to PHYLINK API

2019-08-01 Thread René van Dorst
Quoting Russell King - ARM Linux admin : Hi, Just a couple of minor points. On Wed, Jul 24, 2019 at 09:25:47PM +0200, René van Dorst wrote: + +static void mt7530_phylink_validate(struct dsa_switch *ds, int port, + unsigned long *supported, +

Re: [PATCH net-next 1/3] net: dsa: mt7530: Convert to PHYLINK API

2019-07-27 Thread Russell King - ARM Linux admin
Hi, Just a couple of minor points. On Wed, Jul 24, 2019 at 09:25:47PM +0200, René van Dorst wrote: > +static void mt7530_phylink_mac_config(struct dsa_switch *ds, int port, > + unsigned int mode, > + const struct phylink_link_sta

[PATCH net-next 1/3] net: dsa: mt7530: Convert to PHYLINK API

2019-07-24 Thread René van Dorst
Convert mt7530 to PHYLINK API Signed-off-by: René van Dorst rfc->v1: * Renamed P5_MODE_* to P5_INTF_SEL_*. fits the function more * Convert if-statement for speed bits to a switch suggested by Daniel Santos * Refactor flow_control pause bits and don't use state->link in mt7530_phylink_mac_co