Re: [PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-29 Thread Allan W. Nielsen
On 28/11/16 21:21, Andrew Lunn wrote: > On Mon, Nov 28, 2016 at 08:23:06PM +0100, Allan W. Nielsen wrote: > > On 28/11/16 15:14, Andrew Lunn wrote: > > > On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote: > > > > From: Raju Lakkaraju > > > > 3 types of PHY loopback are supported. >

Re: [PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-28 Thread Andrew Lunn
> > If you really do what to do this, you should look at NETIF_F_LOOPBACK > > and consider how this concept can be applied at the PHY, not the MAC. > > But you need the full concept, so you see things like: > > > > 2: eth0: mtu 1500 qdisc > > pfifo_fast state UP mode DEFAULT group default qlen 1

Re: [PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-28 Thread Florian Fainelli
On 11/28/2016 12:21 PM, Andrew Lunn wrote: > On Mon, Nov 28, 2016 at 08:23:06PM +0100, Allan W. Nielsen wrote: >> Hi Andrew and Florian, >> >> On 28/11/16 15:14, Andrew Lunn wrote: >>> On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote: From: Raju Lakkaraju 3 types of

Re: [PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-28 Thread Andrew Lunn
On Mon, Nov 28, 2016 at 08:23:06PM +0100, Allan W. Nielsen wrote: > Hi Andrew and Florian, > > On 28/11/16 15:14, Andrew Lunn wrote: > > On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote: > > > From: Raju Lakkaraju > > > > > > 3 types of PHY loopback are supported. > > > i.e. Near-

Re: [PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-28 Thread Allan W. Nielsen
Hi Andrew and Florian, On 28/11/16 15:14, Andrew Lunn wrote: > On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote: > > From: Raju Lakkaraju > > > > 3 types of PHY loopback are supported. > > i.e. Near-End Loopback, Far-End Loopback and External Loopback. > Is this integrated with et

Re: [PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-28 Thread Florian Fainelli
On 11/28/2016 06:14 AM, Andrew Lunn wrote: > On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote: >> From: Raju Lakkaraju >> >> 3 types of PHY loopback are supported. >> i.e. Near-End Loopback, Far-End Loopback and External Loopback. > > Hi Allan > > Is this integrated with ethtool

Re: [PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-28 Thread Andrew Lunn
On Mon, Nov 28, 2016 at 02:24:30PM +0100, Allan W. Nielsen wrote: > From: Raju Lakkaraju > > 3 types of PHY loopback are supported. > i.e. Near-End Loopback, Far-End Loopback and External Loopback. Hi Allan Is this integrated with ethtool --test? You only want the PHY to go into loopback mode w

[PATCH net-next 1/3] ethtool: (uapi) Add ETHTOOL_PHY_LOOPBACK to PHY tunables

2016-11-28 Thread Allan W. Nielsen
From: Raju Lakkaraju 3 types of PHY loopback are supported. i.e. Near-End Loopback, Far-End Loopback and External Loopback. Near-End Loopback: Transmitted data (TXD) is looped back in the PCS block onto the receive data signal (RXD). When Near-End loopback enable, no data is transmitted over the