Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 1:07 PM, David Miller wrote: > From: Roopa Prabhu > Date: Fri, 20 Jan 2017 23:43:18 -0800 > >> /* Purge the forwarding table */ >> -static void vxlan_flush(struct vxlan_dev *vxlan) >> +static void vxlan_flush(struct vxlan_dev *vxlan, int do_all) > Please use 'bool' and true/false for

Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-23 Thread David Miller
From: Roopa Prabhu Date: Fri, 20 Jan 2017 23:43:18 -0800 > /* Purge the forwarding table */ > -static void vxlan_flush(struct vxlan_dev *vxlan) > +static void vxlan_flush(struct vxlan_dev *vxlan, int do_all) Please use 'bool' and true/false for this new argument. FWIW, I am fine with changing

Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-23 Thread Roopa Prabhu
On 1/23/17, 12:55 AM, Jiri Benc wrote: > On Fri, 20 Jan 2017 23:43:18 -0800, Roopa Prabhu wrote: >> This patch skips flushing static fdb entries in >> ndo_stop, but flushes all fdb entries during vxlan >> device delete. This is consistent with the bridge >> driver fdb > This makes sense but isn't t

Re: [PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-23 Thread Jiri Benc
On Fri, 20 Jan 2017 23:43:18 -0800, Roopa Prabhu wrote: > This patch skips flushing static fdb entries in > ndo_stop, but flushes all fdb entries during vxlan > device delete. This is consistent with the bridge > driver fdb This makes sense but isn't this a uAPI change? Do you know whether there a

[PATCH net-next 1/2] vxlan: don't flush static fdb entries on admin down

2017-01-20 Thread Roopa Prabhu
From: Roopa Prabhu This patch skips flushing static fdb entries in ndo_stop, but flushes all fdb entries during vxlan device delete. This is consistent with the bridge driver fdb Signed-off-by: Roopa Prabhu --- drivers/net/vxlan.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-)