Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-10 Thread Andrew Lunn
> It wouldn't be trivial. The stats are queried from the driver. So are page pool stats, with the increments happening in the page pool code, not the driver. Andrew

RE: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-10 Thread Dan Jurgens
b...@redhat.com; Jiri Pirko > Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and > wake > > On Thu, May 09, 2024 at 09:19:52PM +, Dan Jurgens wrote: > > > From: Andrew Lunn > > > Sent: Thursday, May 9, 2024 3:47 PM > > > To: Dan Jurgen

Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-10 Thread Andrew Lunn
On Thu, May 09, 2024 at 09:19:52PM +, Dan Jurgens wrote: > > From: Andrew Lunn > > Sent: Thursday, May 9, 2024 3:47 PM > > To: Dan Jurgens > > Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and > > wake > > > > On Thu, May 09

RE: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-09 Thread Dan Jurgens
> Pirko > Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and > wake > > On Thu, 9 May 2024 11:32:15 -0500 Daniel Jurgens wrote: > > diff --git a/tools/include/uapi/linux/netdev.h > > b/tools/include/uapi/linux/netdev.h > > index cf24f1d9adf

Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-09 Thread Jakub Kicinski
On Thu, 9 May 2024 11:32:15 -0500 Daniel Jurgens wrote: > diff --git a/tools/include/uapi/linux/netdev.h > b/tools/include/uapi/linux/netdev.h > index cf24f1d9adf8..ccf6976b1693 100644 > --- a/tools/include/uapi/linux/netdev.h > +++ b/tools/include/uapi/linux/netdev.h > @@ -164,7 +164,8 @@ enum {

RE: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-09 Thread Dan Jurgens
> From: Andrew Lunn > Sent: Thursday, May 9, 2024 3:47 PM > To: Dan Jurgens > Subject: Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and > wake > > On Thu, May 09, 2024 at 11:32:15AM -0500, Daniel Jurgens wrote: > > TX queue stop and wake are counted b

Re: [PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-09 Thread Andrew Lunn
On Thu, May 09, 2024 at 11:32:15AM -0500, Daniel Jurgens wrote: > TX queue stop and wake are counted by some drivers. > Support reporting these via netdev-genl queue stats. > > Signed-off-by: Daniel Jurgens > Reviewed-by: Jiri Pirko > --- > Documentation/netlink/specs/netdev.yaml | 10 +

[PATCH net-next 1/2] netdev: Add queue stats for TX stop and wake

2024-05-09 Thread Daniel Jurgens
TX queue stop and wake are counted by some drivers. Support reporting these via netdev-genl queue stats. Signed-off-by: Daniel Jurgens Reviewed-by: Jiri Pirko --- Documentation/netlink/specs/netdev.yaml | 10 ++ include/net/netdev_queues.h | 3 +++ include/uapi/linux/netdev