Re: [PATCH net-next 1/2] net: phy: make PHY_HALTED a transition state to PHY_READY

2018-12-19 Thread Heiner Kallweit
On 19.12.2018 19:32, Florian Fainelli wrote: > On 12/18/18 10:53 PM, Heiner Kallweit wrote: >> PHY_HALTED and PHY_READY both are non-started states and quite similar. >> Major difference is that phy_start() changes from PHY_HALTED to >> PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does)

Re: [PATCH net-next 1/2] net: phy: make PHY_HALTED a transition state to PHY_READY

2018-12-19 Thread Florian Fainelli
On 12/18/18 10:53 PM, Heiner Kallweit wrote: > PHY_HALTED and PHY_READY both are non-started states and quite similar. > Major difference is that phy_start() changes from PHY_HALTED to > PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does). > > There's no guarantee that PHY registers are

[PATCH net-next 1/2] net: phy: make PHY_HALTED a transition state to PHY_READY

2018-12-18 Thread Heiner Kallweit
PHY_HALTED and PHY_READY both are non-started states and quite similar. Major difference is that phy_start() changes from PHY_HALTED to PHY_RESUMING which doesn't reconfigure aneg (what PHY_UP does). There's no guarantee that PHY registers are completely untouched when waking up from power-down, e