RE: [PATCH net-next 1/2] net: permit skb_segment on head_frag frag_list skb

2018-03-19 Thread Yuan, Linyu (NSB - CN/Shanghai)
- CN/Shanghai); eduma...@google.com; a...@fb.com; > dan...@iogearbox.net; dipt...@fb.com; netdev@vger.kernel.org > Cc: kernel-t...@fb.com > Subject: Re: [PATCH net-next 1/2] net: permit skb_segment on head_frag > frag_list skb > > > > On 3/19/18 10:30 PM, Yuan, Linyu (NSB -

Re: [PATCH net-next 1/2] net: permit skb_segment on head_frag frag_list skb

2018-03-19 Thread Yonghong Song
...@fb.com; netdev@vger.kernel.org Cc: kernel-t...@fb.com Subject: [PATCH net-next 1/2] net: permit skb_segment on head_frag frag_list skb while (pos < offset + len) { if (i >= nfrags) { - BUG_ON(skb_headlen(li

RE: [PATCH net-next 1/2] net: permit skb_segment on head_frag frag_list skb

2018-03-19 Thread Yuan, Linyu (NSB - CN/Shanghai)
org > Cc: kernel-t...@fb.com > Subject: [PATCH net-next 1/2] net: permit skb_segment on head_frag frag_list > skb > > > while (pos < offset + len) { > if (i >= nfrags) { > - BUG_ON(skb_headlen(list_skb));

[PATCH net-next 1/2] net: permit skb_segment on head_frag frag_list skb

2018-03-19 Thread Yonghong Song
One of our in-house projects, bpf-based NAT, hits a kernel BUG_ON at function skb_segment(), line 3667. The bpf program attaches to clsact ingress, calls bpf_skb_change_proto to change protocol from ipv4 to ipv6 or from ipv6 to ipv4, and then calls bpf_redirect to send the changed packet out. 3472