Re: [PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-30 Thread Andrew Lunn
> 'cards_found' doesn't exist for the ixgbe driver. Agh, sorry, i was looking at ixgb, not ixgbe. Andrew

Re: [PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-30 Thread Steve Douthit
On 11/30/18 12:43 PM, Florian Fainelli wrote: > > > On 11/30/2018 9:34 AM, Steve Douthit wrote: >> On 11/30/18 11:34 AM, Andrew Lunn wrote: Yep, registering multiple interfaces is wrong. The first board I tested against only had a single MAC enabled (they can be disabled/hidden via >>>

Re: [PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-30 Thread Florian Fainelli
On 11/30/2018 9:34 AM, Steve Douthit wrote: > On 11/30/18 11:34 AM, Andrew Lunn wrote: >>> Yep, registering multiple interfaces is wrong. The first board I tested >>> against only had a single MAC enabled (they can be disabled/hidden via >>> straps) so it just happened to work. >> >> Hi Steve >

Re: [PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-30 Thread Steve Douthit
On 11/30/18 11:34 AM, Andrew Lunn wrote: >> Yep, registering multiple interfaces is wrong. The first board I tested >> against only had a single MAC enabled (they can be disabled/hidden via >> straps) so it just happened to work. > > Hi Steve > > Can you hide any/all via straps, or is 00.0 alway

Re: [PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-30 Thread Andrew Lunn
> Yep, registering multiple interfaces is wrong. The first board I tested > against only had a single MAC enabled (they can be disabled/hidden via > straps) so it just happened to work. Hi Steve Can you hide any/all via straps, or is 00.0 always guaranteed to exist? > The Intel C3xxx family of

Re: [PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-30 Thread Steve Douthit
On 11/30/18 8:21 AM, Andrew Lunn wrote: > Hi Steve > > Cool to see another interface being made DSA capable. > >> +/** >> + * ixgbe_msca - Write the command register and poll for completion/timeout >> + * @hw: pointer to hardware structure >> + * @cmd: command register value to write >> + **/

Re: [PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-30 Thread Andrew Lunn
Hi Steve Cool to see another interface being made DSA capable. > +/** > + * ixgbe_msca - Write the command register and poll for completion/timeout > + * @hw: pointer to hardware structure > + * @cmd: command register value to write > + **/ > +static s32 ixgbe_msca_cmd(struct ixgbe_hw *hw, u32

[PATCH net-next 1/2] ixgbe: register a mdiobus

2018-11-29 Thread Steve Douthit
Most dsa devices expect a 'struct mii_bus' pointer to talk to switches via the MII interface. Signed-off-by: Stephen Douthit --- drivers/net/ethernet/intel/ixgbe/ixgbe.h | 2 + drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 6 + drivers/net/ethernet/intel/ixgbe/ixgbe_phy.c | 192 +