> Not to confuse Dave with the discussion:
> This is not about whether the patch is wrong or right, but about how
> a future architecture based on ethtool-nl could look like.
>
> Like Michael said, based on the current ethtool architecture it's simple:
> Driver will choose closest supported value.
On 26.03.2019 10:17, Michal Kubecek wrote:
> On Tue, Mar 26, 2019 at 09:24:38AM +0100, Andrew Lunn wrote:
+#define ETHTOOL_PHY_FAST_LINK_DOWN_ON 0
+#define ETHTOOL_PHY_FAST_LINK_DOWN_OFF0xff
+
enum phy_tunable_id {
ETHTOOL_PHY_ID_UNSPEC,
ETHTOOL_PHY_DOWN
On 26.03.2019 09:24, Andrew Lunn wrote:
>>> +#define ETHTOOL_PHY_FAST_LINK_DOWN_ON 0
>>> +#define ETHTOOL_PHY_FAST_LINK_DOWN_OFF 0xff
>>> +
>>> enum phy_tunable_id {
>>> ETHTOOL_PHY_ID_UNSPEC,
>>> ETHTOOL_PHY_DOWNSHIFT,
>>> + ETHTOOL_PHY_FAST_LINK_DOWN,
>>> /*
>>> * Add
On Tue, Mar 26, 2019 at 09:24:38AM +0100, Andrew Lunn wrote:
> > > +#define ETHTOOL_PHY_FAST_LINK_DOWN_ON0
> > > +#define ETHTOOL_PHY_FAST_LINK_DOWN_OFF 0xff
> > > +
> > > enum phy_tunable_id {
> > > ETHTOOL_PHY_ID_UNSPEC,
> > > ETHTOOL_PHY_DOWNSHIFT,
> > > + ETHTOOL_PHY_FAST_LINK_DOWN,
> > +#define ETHTOOL_PHY_FAST_LINK_DOWN_ON 0
> > +#define ETHTOOL_PHY_FAST_LINK_DOWN_OFF 0xff
> > +
> > enum phy_tunable_id {
> > ETHTOOL_PHY_ID_UNSPEC,
> > ETHTOOL_PHY_DOWNSHIFT,
> > + ETHTOOL_PHY_FAST_LINK_DOWN,
> > /*
> > * Add your fresh new phy tunable attribute ab
On 25.03.2019 18:49, Michal Kubecek wrote:
> On Sun, Mar 24, 2019 at 04:02:43PM +0100, Heiner Kallweit wrote:
>> This adds support for Fast Link Down as new PHY tunable.
>> Fast Link Down reduces the time until a link down event is reported
>> for 1000BaseT. According to the standard it's 750ms wha
On Sun, Mar 24, 2019 at 04:02:43PM +0100, Heiner Kallweit wrote:
> This adds support for Fast Link Down as new PHY tunable.
> Fast Link Down reduces the time until a link down event is reported
> for 1000BaseT. According to the standard it's 750ms what is too long
> for several use cases.
>
> Sign
This adds support for Fast Link Down as new PHY tunable.
Fast Link Down reduces the time until a link down event is reported
for 1000BaseT. According to the standard it's 750ms what is too long
for several use cases.
Signed-off-by: Heiner Kallweit
---
include/uapi/linux/ethtool.h | 4
net/c
