Re: [PATCH net-next 1/2] e1000e: Leverage direct_complete to speed up s2ram

2021-03-16 Thread Chen Yu
Hi Jakub, thanks for taking a look! On Mon, Mar 15, 2021 at 02:04:22PM -0700, Jakub Kicinski wrote: > On Mon, 15 Mar 2021 12:02:30 -0700 Tony Nguyen wrote: > > +static __maybe_unused int e1000e_pm_prepare(struct device *dev) > > +{ > > + return pm_runtime_suspended(dev) && > > + pm_susp

Re: [PATCH net-next 1/2] e1000e: Leverage direct_complete to speed up s2ram

2021-03-15 Thread Jakub Kicinski
On Mon, 15 Mar 2021 12:02:30 -0700 Tony Nguyen wrote: > +static __maybe_unused int e1000e_pm_prepare(struct device *dev) > +{ > + return pm_runtime_suspended(dev) && > + pm_suspend_via_firmware(); nit: I don't think you need to mark functions called by __maybe_unused as __mayb

[PATCH net-next 1/2] e1000e: Leverage direct_complete to speed up s2ram

2021-03-15 Thread Tony Nguyen
From: Chen Yu The NIC is put in runtime suspend status when there is no cable connected. As a result, it is safe to keep non-wakeup NIC in runtime suspended during s2ram because the system does not rely on the NIC plug event nor WoL to wake up the system. Besides that, unlike the s2idle, s2ram do