Re: [PATCH net-next 1/2] Revert "devlink: Add a generic wake_on_lan port parameter"

2019-02-08 Thread kbuild test robot
Hi Vasundhara, Thank you for the patch! Yet something to improve: [auto build test ERROR on net-next/master] url: https://github.com/0day-ci/linux/commits/Vasundhara-Volam/Revert-wake_on_lan-devlink-parameter/20190208-181949 config: i386-randconfig-x000-201905 (attached as .config) compiler:

[PATCH net-next 1/2] Revert "devlink: Add a generic wake_on_lan port parameter"

2019-02-08 Thread Vasundhara Volam
This reverts commit b639583f9e36d044ac1b13090ae812266992cbac. As per discussion with Jakub Kicinski and Michal Kubecek, this will be better addressed by soon-too-come ethtool netlink API with additional indication that given configuration request is supposed to be persisted. Cc: Jiri Pirko Cc: M