Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-31 Thread Subash Abhinov Kasiviswanathan
Yeah, seems quite a bit like VLAN (from a workflow perspective, not quite as much from a protocol one) and I think the same workflow could work for this too. Would be nice to eventually get qmi_wwan onto the same base, if possible (though we'd need to preserve the 802.3 capability somehow for dev

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-31 Thread Dan Williams
On Fri, 2017-03-24 at 18:49 -0600, Subash Abhinov Kasiviswanathan wrote: > > (re-sending from an address that's actually subscribed to > > netdev@...) > > > > The first thing that jumps out at me is "why isn't this using > > rtnl_link_ops?" > > > > To me (and perhaps I'm completely wrong) the str

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-24 Thread Subash Abhinov Kasiviswanathan
(re-sending from an address that's actually subscribed to netdev@...) The first thing that jumps out at me is "why isn't this using rtnl_link_ops?" To me (and perhaps I'm completely wrong) the structure here is a lot like VLAN interfaces.  You have a base device (whether that's a netdev or not)

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-24 Thread Dan Williams
On Mon, 2017-03-13 at 01:43 -0600, Subash Abhinov Kasiviswanathan wrote: > RmNet Data driver provides a transport agnostic MAP (multiplexing and > aggregation protocol) support in embedded and bridge modes. Module > provides virtual network devices which can be attached to any IP-mode > physical de

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-24 Thread Dan Williams
On Mon, 2017-03-13 at 01:43 -0600, Subash Abhinov Kasiviswanathan wrote: > RmNet Data driver provides a transport agnostic MAP (multiplexing and > aggregation protocol) support in embedded and bridge modes. Module > provides virtual network devices which can be attached to any IP-mode > physical de

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-14 Thread Subash Abhinov Kasiviswanathan
I believe that this code should be a part of that driver, not a generic code in net/ ok, so? Hi Jiri I will move it to drivers/net and rename it to rmnet. -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collabor

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-13 Thread Jiri Pirko
Mon, Mar 13, 2017 at 11:01:15PM CET, subas...@codeaurora.org wrote: >On 2017-03-13 02:54, Jiri Pirko wrote: >> Mon, Mar 13, 2017 at 08:43:09AM CET, subas...@codeaurora.org wrote: >> > RmNet Data driver provides a transport agnostic MAP (multiplexing and >> >> Why "data"? Why not just "rmnet"?? >>

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-13 Thread kbuild test robot
Hi Subash, [auto build test WARNING on net-next/master] url: https://github.com/0day-ci/linux/commits/Subash-Abhinov-Kasiviswanathan/net-rmnet_data-Initial-implementation/20170313-174754 reproduce: # apt-get install sparse make ARCH=x86_64 allmodconfig make C=1 CF=-D__

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-13 Thread Subash Abhinov Kasiviswanathan
On 2017-03-13 02:54, Jiri Pirko wrote: Mon, Mar 13, 2017 at 08:43:09AM CET, subas...@codeaurora.org wrote: RmNet Data driver provides a transport agnostic MAP (multiplexing and Why "data"? Why not just "rmnet"?? Btw, what is "RmNet". Google does not give me much. Is it some priprietady Qualco

Re: [PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-13 Thread Jiri Pirko
Mon, Mar 13, 2017 at 08:43:09AM CET, subas...@codeaurora.org wrote: >RmNet Data driver provides a transport agnostic MAP (multiplexing and Why "data"? Why not just "rmnet"?? Btw, what is "RmNet". Google does not give me much. Is it some priprietady Qualcomm thing? Is there some standard behind it

[PATCH net-next 1/1 v2] net: rmnet_data: Initial implementation

2017-03-13 Thread Subash Abhinov Kasiviswanathan
RmNet Data driver provides a transport agnostic MAP (multiplexing and aggregation protocol) support in embedded and bridge modes. Module provides virtual network devices which can be attached to any IP-mode physical device. This will be used to provide all MAP functionality on future hardware in a