Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-19 Thread Jamal Hadi Salim
On 17-04-18 11:55 PM, Jakub Kicinski wrote: On Tue, 18 Apr 2017 21:37:12 -0400, Jamal Hadi Salim wrote: On 17-04-18 06:12 PM, Jakub Kicinski wrote: [..] I see both being fine from that perspective - you dont need 100% accuracy. Just something that is within reason of a small delta of time.

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-18 Thread Jakub Kicinski
On Tue, 18 Apr 2017 21:37:12 -0400, Jamal Hadi Salim wrote: > On 17-04-18 06:12 PM, Jakub Kicinski wrote: > > > Noob question - would it be an option to establish some form of > > streaming statistic updates out of the kernel? > > It would be more efficient, certainly. Current polling approach

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-18 Thread Jamal Hadi Salim
On 17-04-18 06:12 PM, Jakub Kicinski wrote: Noob question - would it be an option to establish some form of streaming statistic updates out of the kernel? It would be more efficient, certainly. Current polling approach is not as bad though (you send one extra kernel message) and is more reliab

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-18 Thread Jakub Kicinski
On Sun, 16 Apr 2017 09:56:13 -0400, Jamal Hadi Salim wrote: > From: Jamal Hadi Salim > > This adds support for filtering based on time since last used. > When we are dumping a large number of actions it is useful to > have the option of filtering based on when the action was last > used to reduce

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-17 Thread Jiri Pirko
Sun, Apr 16, 2017 at 03:56:13PM CEST, j...@mojatatu.com wrote: >From: Jamal Hadi Salim > >This adds support for filtering based on time since last used. >When we are dumping a large number of actions it is useful to >have the option of filtering based on when the action was last >used to reduce th

Re: [PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-16 Thread Jamal Hadi Salim
I should say this is dependent on the earlier patch I posted. Made them separate because I think this one in particular may generate some discussions. cheers, jamal On 17-04-16 09:56 AM, Jamal Hadi Salim wrote: From: Jamal Hadi Salim This adds support for filtering based on time since last u

[PATCH net-next 1/1] net sched actions: add time filter for action dumping

2017-04-16 Thread Jamal Hadi Salim
From: Jamal Hadi Salim This adds support for filtering based on time since last used. When we are dumping a large number of actions it is useful to have the option of filtering based on when the action was last used to reduce the amount of data crossing to user space. With this patch the user sp