Re: [PATCH net-next 09/12] ionic: change mtu without full queue rebuild

2020-08-26 Thread Shannon Nelson
On 8/26/20 2:09 PM, Jakub Kicinski wrote: On Wed, 26 Aug 2020 09:42:11 -0700 Shannon Nelson wrote: + mutex_lock(&lif->queue_lock); + netif_device_detach(lif->netdev); + ionic_stop_queues(lif); + ionic_txrx_deinit(lif); + err = ionic_txrx_init(lif); + if (err) +

Re: [PATCH net-next 09/12] ionic: change mtu without full queue rebuild

2020-08-26 Thread Jakub Kicinski
On Wed, 26 Aug 2020 09:42:11 -0700 Shannon Nelson wrote: > + mutex_lock(&lif->queue_lock); > + netif_device_detach(lif->netdev); > + ionic_stop_queues(lif); > + ionic_txrx_deinit(lif); > > + err = ionic_txrx_init(lif); > + if (err) > + goto err_out; > + > +

[PATCH net-next 09/12] ionic: change mtu without full queue rebuild

2020-08-26 Thread Shannon Nelson
We really don't need to tear down and rebuild the whole queue structure when changing the MTU; we can simply stop the queues, clean and refill, then restart the queues. Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_lif.c | 45 --- 1 file changed, 38 in