Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext

2017-04-28 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> +/* Write the VID to iterate from only once */ >> +if (!entry->valid) { >> +err = mv88e6xxx_g1_vtu_vid_write(chip, entry); >> +if (err) >> +return err; >> +} > > Please could you add a bigger comment. It is

Re: [PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext

2017-04-27 Thread Andrew Lunn
On Wed, Apr 26, 2017 at 11:53:26AM -0400, Vivien Didelot wrote: > Even though every switch model has a different way to access the VTU > Data bits, the base implementation of the VTU GetNext operation remains > the same: wait, write the first VID to iterate from, start the > operation, and read the

[PATCH net-next 08/18] net: dsa: mv88e6xxx: move generic VTU GetNext

2017-04-26 Thread Vivien Didelot
Even though every switch model has a different way to access the VTU Data bits, the base implementation of the VTU GetNext operation remains the same: wait, write the first VID to iterate from, start the operation, and read the next VID. Move this generic implementation into global_vtu.c and abstr