Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

2018-07-04 Thread Heiner Kallweit
On 04.07.2018 16:46, Andrew Lunn wrote: > On Mon, Jul 02, 2018 at 11:54:54PM +0200, Heiner Kallweit wrote: >> On 02.07.2018 23:21, Andrew Lunn wrote: - auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; >>> >>> This bit you probably want to keep. The PHY never says it support >>

Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

2018-07-04 Thread Andrew Lunn
On Mon, Jul 02, 2018 at 11:54:54PM +0200, Heiner Kallweit wrote: > On 02.07.2018 23:21, Andrew Lunn wrote: > >> - auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; > > > > This bit you probably want to keep. The PHY never says it support > > Pause. The MAC needs to enable pause if

Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

2018-07-02 Thread Heiner Kallweit
On 02.07.2018 23:21, Andrew Lunn wrote: >> -auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; > > This bit you probably want to keep. The PHY never says it support > Pause. The MAC needs to enable pause if the MAC supports pause. > Actually I assumed that phylib would do this f

Re: [PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

2018-07-02 Thread Andrew Lunn
> - auto_nego |= ADVERTISE_PAUSE_CAP | ADVERTISE_PAUSE_ASYM; This bit you probably want to keep. The PHY never says it support Pause. The MAC needs to enable pause if the MAC supports pause. Andrew

[PATCH net-next 08/10] r8169: remove rtl8169_set_speed_xmii

2018-07-02 Thread Heiner Kallweit
We can remove rtl8169_set_speed_xmii() now that phylib handles all this. Signed-off-by: Heiner Kallweit --- drivers/net/ethernet/realtek/r8169.c | 90 1 file changed, 90 deletions(-) diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r