Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-19 Thread Tom Herbert
On Tue, Sep 19, 2017 at 10:42 AM, David Miller wrote: > From: Harald Welte > Date: Tue, 19 Sep 2017 20:12:45 +0800 > >> Hi Dave, >> >> On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote: >> >>> > +static inline u32 ipv6_hashfn(const struct in6_addr *a) >>> > +{ >>> > + return __ipv6_ad

Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-19 Thread David Miller
From: Harald Welte Date: Tue, 19 Sep 2017 20:12:45 +0800 > Hi Dave, > > On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote: > >> > +static inline u32 ipv6_hashfn(const struct in6_addr *a) >> > +{ >> > + return __ipv6_addr_jhash(a, gtp_h_initval); >> > +} >> >> I know you are just fo

Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-19 Thread Harald Welte
Hi Dave, On Mon, Sep 18, 2017 at 09:19:08PM -0700, David Miller wrote: > > +static inline u32 ipv6_hashfn(const struct in6_addr *a) > > +{ > > + return __ipv6_addr_jhash(a, gtp_h_initval); > > +} > > I know you are just following the pattern of the existing "ipv4_hashfn()" here > but this kind

Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-19 Thread Harald Welte
On Mon, Sep 18, 2017 at 05:38:57PM -0700, Tom Herbert wrote: > Allow IPv6 mobile subscriber packets. This entails adding an IPv6 mobile > subscriber address to pdp context and IPv6 specific variants to find pdp > contexts by address. Please note that there are three different PDP contexts for IP:

Re: [PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-18 Thread David Miller
From: Tom Herbert Date: Mon, 18 Sep 2017 17:38:57 -0700 > @@ -98,6 +104,7 @@ static void pdp_context_delete(struct pdp_ctx *pctx); > static inline u32 gtp0_hashfn(u64 tid) > { > u32 *tid32 = (u32 *) &tid; > + > return jhash_2words(tid32[0], tid32[1], gtp_h_initval); > } > > @@ -1

[PATCH net-next 07/14] gtp: Support encapsulation of IPv6 packets

2017-09-18 Thread Tom Herbert
Allow IPv6 mobile subscriber packets. This entails adding an IPv6 mobile subscriber address to pdp context and IPv6 specific variants to find pdp contexts by address. Signed-off-by: Tom Herbert --- drivers/net/gtp.c| 259 +-- include/uapi/linux