Re: [PATCH net-next 06/21] net: dsa: mv88e6xxx: factorize MAC address setting

2016-05-07 Thread Vivien Didelot
Hi Andrew, Andrew Lunn writes: >> @@ -378,6 +385,7 @@ enum mv88e6xxx_cap { >> #define MV88E6XXX_FLAG_EEPROM BIT(MV88E6XXX_CAP_EEPROM) >> #define MV88E6XXX_FLAG_PPU BIT(MV88E6XXX_CAP_PPU) >> #define MV88E6XXX_FLAG_SMI_PHY BIT(MV88E6XXX_CAP_SMI_PHY) >> +#defi

Re: [PATCH net-next 06/21] net: dsa: mv88e6xxx: factorize MAC address setting

2016-05-06 Thread Andrew Lunn
> @@ -378,6 +385,7 @@ enum mv88e6xxx_cap { > #define MV88E6XXX_FLAG_EEPROMBIT(MV88E6XXX_CAP_EEPROM) > #define MV88E6XXX_FLAG_PPU BIT(MV88E6XXX_CAP_PPU) > #define MV88E6XXX_FLAG_SMI_PHY BIT(MV88E6XXX_CAP_SMI_PHY) > +#define MV88E6XXX_FLAG_SWITCH_MACBIT(

[PATCH net-next 06/21] net: dsa: mv88e6xxx: factorize MAC address setting

2016-05-06 Thread Vivien Didelot
Some switch models have a dedicated register for Switch MAC/WoF/WoL. This register, when present, is used to indirectly set the switch MAC address, instead of a direct write to 3 global registers. Identify this feature and share a common mv88e6xxx_set_addr function. Signed-off-by: Vivien Didelot