Re: [PATCH net-next 05/14] net: macb: Use net_device_stats from struct net_device

2017-04-07 Thread David Miller
From: Tobias Klauser Date: Fri, 7 Apr 2017 10:57:09 +0200 > With a quick git/google search I couldn't really find any information on > why net_device_stats was deemed legacy and whether it is still allowed > to be used. It seems the comment saying so was introduced in > 536721b1cb3f ("net: kernel

Re: [PATCH net-next 05/14] net: macb: Use net_device_stats from struct net_device

2017-04-07 Thread Tobias Klauser
On 2017-04-07 at 10:29:34 +0200, Nicolas Ferre wrote: > Le 07/04/2017 à 10:17, Tobias Klauser a écrit : > > Instead of using a private copy of struct net_device_stats in struct > > macb, use stats from struct net_device. > > I agree with the initiative but I read this in the documentation of thi

Re: [PATCH net-next 05/14] net: macb: Use net_device_stats from struct net_device

2017-04-07 Thread Nicolas Ferre
Le 07/04/2017 à 10:17, Tobias Klauser a écrit : > Instead of using a private copy of struct net_device_stats in struct > macb, use stats from struct net_device. I agree with the initiative but I read this in the documentation of this struct member... @stats: Statistics struct, which was l

[PATCH net-next 05/14] net: macb: Use net_device_stats from struct net_device

2017-04-07 Thread Tobias Klauser
Instead of using a private copy of struct net_device_stats in struct macb, use stats from struct net_device. Cc: Nicolas Ferre Signed-off-by: Tobias Klauser --- drivers/net/ethernet/cadence/macb.c | 40 ++--- drivers/net/ethernet/cadence/macb.h | 1 - 2 files ch