Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-06 Thread Shannon Nelson
On 4/6/21 5:27 PM, Richard Cochran wrote: On Tue, Apr 06, 2021 at 04:18:00PM -0700, Shannon Nelson wrote: On 4/5/21 11:17 AM, Richard Cochran wrote: On Mon, Apr 05, 2021 at 09:16:39AM -0700, Shannon Nelson wrote: On 4/4/21 4:05 PM, Richard Cochran wrote: This check is unneeded, because the io

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-06 Thread Richard Cochran
On Tue, Apr 06, 2021 at 04:18:00PM -0700, Shannon Nelson wrote: > On 4/5/21 11:17 AM, Richard Cochran wrote: > > On Mon, Apr 05, 2021 at 09:16:39AM -0700, Shannon Nelson wrote: > > > On 4/4/21 4:05 PM, Richard Cochran wrote: > > > > This check is unneeded, because the ioctl layer never passes NULL

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-06 Thread Shannon Nelson
On 4/5/21 11:17 AM, Richard Cochran wrote: On Mon, Apr 05, 2021 at 09:16:39AM -0700, Shannon Nelson wrote: On 4/4/21 4:05 PM, Richard Cochran wrote: This check is unneeded, because the ioctl layer never passes NULL here. Yes, the ioctl layer never calls this with NULL, but we call it from with

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-05 Thread Richard Cochran
On Mon, Apr 05, 2021 at 09:16:39AM -0700, Shannon Nelson wrote: > On 4/4/21 4:05 PM, Richard Cochran wrote: > > This check is unneeded, because the ioctl layer never passes NULL here. > > Yes, the ioctl layer never calls this with NULL, but we call it from within > the driver when we spin operatio

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-05 Thread Shannon Nelson
On 4/4/21 4:21 PM, Richard Cochran wrote: On Thu, Apr 01, 2021 at 10:56:03AM -0700, Shannon Nelson wrote: +int ionic_lif_hwstamp_set(struct ionic_lif *lif, struct ifreq *ifr) +{ + struct ionic *ionic = lif->ionic; + struct hwtstamp_config config; + int tx_mode = 0; + u64

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-05 Thread Shannon Nelson
On 4/4/21 4:05 PM, Richard Cochran wrote: On Thu, Apr 01, 2021 at 10:56:03AM -0700, Shannon Nelson wrote: @@ -0,0 +1,589 @@ +// SPDX-License-Identifier: GPL-2.0 +/* Copyright(c) 2017 - 2021 Pensando Systems, Inc */ + +#include +#include + +#include "ionic.h" +#include "ionic_bus.h" +#include "

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-04 Thread Leon Romanovsky
On Sun, Apr 04, 2021 at 04:05:26PM -0700, Richard Cochran wrote: > On Thu, Apr 01, 2021 at 10:56:03AM -0700, Shannon Nelson wrote: > > @@ -0,0 +1,589 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* Copyright(c) 2017 - 2021 Pensando Systems, Inc */ > > + > > +#include > > +#include > > + > > +

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-04 Thread Richard Cochran
On Thu, Apr 01, 2021 at 10:56:03AM -0700, Shannon Nelson wrote: > +int ionic_lif_hwstamp_set(struct ionic_lif *lif, struct ifreq *ifr) > +{ > + struct ionic *ionic = lif->ionic; > + struct hwtstamp_config config; > + int tx_mode = 0; > + u64 rx_filt = 0; > + int err, err2; > +

Re: [PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-04 Thread Richard Cochran
On Thu, Apr 01, 2021 at 10:56:03AM -0700, Shannon Nelson wrote: > @@ -0,0 +1,589 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* Copyright(c) 2017 - 2021 Pensando Systems, Inc */ > + > +#include > +#include > + > +#include "ionic.h" > +#include "ionic_bus.h" > +#include "ionic_lif.h" > +#include

[PATCH net-next 05/12] ionic: add hw timestamp support files

2021-04-01 Thread Shannon Nelson
This adds the file of code for supporting Tx and Rx hardware timestamps and the raw clock interface, but does not yet link it in for compiling or use. Signed-off-by: Allen Hubbe Signed-off-by: Shannon Nelson --- .../net/ethernet/pensando/ionic/ionic_phc.c | 589 ++ 1 file chan