Re: [PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-07-03 Thread Jiri Pirko
Wed, Jun 26, 2019 at 03:16:26PM CEST, pa...@netfilter.org wrote: >On Wed, Jun 26, 2019 at 02:12:56PM +0200, Jiri Pirko wrote: >> Tue, Jun 25, 2019 at 10:31:54AM CEST, pa...@netfilter.org wrote: >> >On Fri, Jun 21, 2019 at 07:16:03PM +0200, Jiri Pirko wrote: >> >> Thu, Jun 20, 2019 at 09:49:09PM CES

Re: [PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-06-26 Thread Pablo Neira Ayuso
On Wed, Jun 26, 2019 at 02:12:56PM +0200, Jiri Pirko wrote: > Tue, Jun 25, 2019 at 10:31:54AM CEST, pa...@netfilter.org wrote: > >On Fri, Jun 21, 2019 at 07:16:03PM +0200, Jiri Pirko wrote: > >> Thu, Jun 20, 2019 at 09:49:09PM CEST, pa...@netfilter.org wrote: > >> > >> [...] > >> > >> > > >> >+s

Re: [PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-06-26 Thread Jiri Pirko
Tue, Jun 25, 2019 at 10:31:54AM CEST, pa...@netfilter.org wrote: >On Fri, Jun 21, 2019 at 07:16:03PM +0200, Jiri Pirko wrote: >> Thu, Jun 20, 2019 at 09:49:09PM CEST, pa...@netfilter.org wrote: >> >> [...] >> >> > >> >+static LIST_HEAD(tcf_block_cb_list); >> >> I still don't like the global lis

Re: [PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-06-25 Thread Pablo Neira Ayuso
On Fri, Jun 21, 2019 at 07:16:03PM +0200, Jiri Pirko wrote: > Thu, Jun 20, 2019 at 09:49:09PM CEST, pa...@netfilter.org wrote: > > [...] > > > > >+static LIST_HEAD(tcf_block_cb_list); > > I still don't like the global list. Have to go throught the code more > carefully, but why you can't pass t

Re: [PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-06-21 Thread Jiri Pirko
Thu, Jun 20, 2019 at 09:49:09PM CEST, pa...@netfilter.org wrote: [...] > >+static LIST_HEAD(tcf_block_cb_list); I still don't like the global list. Have to go throught the code more carefully, but why you can't pass the priv/ctx from tc/netfilter. From tc it would be tcf_block as it is now, fro

[PATCH net-next 04/12] net: sched: add tcf_block_setup()

2019-06-20 Thread Pablo Neira Ayuso
This new function allows us to handle tcf_block_cb registrations / unregistrations from the core, in order to remove a dependency with the tcf_block object and the .reoffload cls_api callback. The tcf_block_cb_add() call places the tcf_block_cb object, which has been set up by the driver, in the t