Re: [PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-14 Thread David Ahern
On 8/14/15 9:16 PM, Tom Herbert wrote: At least collect this code into one (static inline) function to better minimize the code churn in udp. If this is general functionality that can be used by other drivers then abstract it out as such. Also, if the VRF driver is not configured it seems like th

Re: [PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-14 Thread Tom Herbert
On Fri, Aug 14, 2015 at 10:58 AM, Shrijeet Mukherjee wrote: > > > On Fri, Aug 14, 2015 at 9:27 AM, Tom Herbert wrote: >> >> On Thu, Aug 13, 2015 at 1:59 PM, David Ahern >> wrote: >> > For unconnected UDP sockets using a VRF device lookup source address >> > based on VRF table. This allows the UD

Re: [PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-14 Thread Tom Herbert
On Thu, Aug 13, 2015 at 1:59 PM, David Ahern wrote: > For unconnected UDP sockets using a VRF device lookup source address > based on VRF table. This allows the UDP header to be properly setup > before showing up at the VRF device via the dst. > > Signed-off-by: Shrijeet Mukherjee > Signed-off-by

[PATCH net-next 04/11] udp: Handle VRF device in sendmsg

2015-08-13 Thread David Ahern
For unconnected UDP sockets using a VRF device lookup source address based on VRF table. This allows the UDP header to be properly setup before showing up at the VRF device via the dst. Signed-off-by: Shrijeet Mukherjee Signed-off-by: David Ahern --- net/ipv4/udp.c | 22 +-