Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-05 Thread Jacob Keller
On 10/3/2020 8:04 AM, Jakub Kicinski wrote: > On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote: >>> enum devlink_attr { >>> /* don't change the order or add anything between, this is ABI! */ >>> DEVLINK_ATTR_UNSPEC, >>> @@ -507,6 +524,7 @@ enum devlink_attr { >>> >>> DEVLINK_ATTR_R

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-05 Thread Jacob Keller
On 10/1/2020 6:59 AM, Moshe Shemesh wrote: > Add reload limit to demand restrictions on reload actions. > Reload limits supported: > no_reset: No reset allowed, no down time allowed, no link flap and no > configuration is lost. > > By default reload limit is unspecified and so no cons

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-05 Thread Jiri Pirko
Sun, Oct 04, 2020 at 08:42:47AM CEST, mo...@nvidia.com wrote: > >On 10/3/2020 10:51 AM, Jiri Pirko wrote: >> Thu, Oct 01, 2020 at 03:59:06PM CEST, mo...@mellanox.com wrote: >> >> [...] >> >> > enum devlink_attr { >> >/* don't change the order or add anything between, this is ABI! */ >> >D

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-04 Thread Moshe Shemesh
On 10/3/2020 6:04 PM, Jakub Kicinski wrote: External email: Use caution opening links or attachments On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote: enum devlink_attr { /* don't change the order or add anything between, this is ABI! */ DEVLINK_ATTR_UNSPEC, @@ -507,6 +524,7 @@ e

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-03 Thread Moshe Shemesh
On 10/3/2020 10:51 AM, Jiri Pirko wrote: Thu, Oct 01, 2020 at 03:59:06PM CEST, mo...@mellanox.com wrote: [...] enum devlink_attr { /* don't change the order or add anything between, this is ABI! */ DEVLINK_ATTR_UNSPEC, @@ -507,6 +524,7 @@ enum devlink_attr { DEVLINK_

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-03 Thread Jakub Kicinski
On Sat, 3 Oct 2020 09:51:00 +0200 Jiri Pirko wrote: > > enum devlink_attr { > > /* don't change the order or add anything between, this is ABI! */ > > DEVLINK_ATTR_UNSPEC, > >@@ -507,6 +524,7 @@ enum devlink_attr { > > > > DEVLINK_ATTR_RELOAD_ACTION, /* u8 */ > > DEVLIN

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-03 Thread Jiri Pirko
Thu, Oct 01, 2020 at 03:59:06PM CEST, mo...@mellanox.com wrote: [...] > enum devlink_attr { > /* don't change the order or add anything between, this is ABI! */ > DEVLINK_ATTR_UNSPEC, >@@ -507,6 +524,7 @@ enum devlink_attr { > > DEVLINK_ATTR_RELOAD_ACTION, /* u8 */

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-02 Thread Moshe Shemesh
On 10/2/2020 12:14 AM, Jakub Kicinski wrote: External email: Use caution opening links or attachments On Thu, 1 Oct 2020 16:59:06 +0300 Moshe Shemesh wrote: @@ -3032,6 +3064,7 @@ devlink_nl_reload_actions_performed_snd(struct devlink *devlink, static int devlink_nl_cmd_reload(struct sk_

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-01 Thread Jakub Kicinski
On Thu, 1 Oct 2020 16:59:06 +0300 Moshe Shemesh wrote: > Add reload limit to demand restrictions on reload actions. > Reload limits supported: > no_reset: No reset allowed, no down time allowed, no link flap and no > configuration is lost. > > By default reload limit is unspecified and

Re: [PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-01 Thread Jakub Kicinski
On Thu, 1 Oct 2020 16:59:06 +0300 Moshe Shemesh wrote: > @@ -3032,6 +3064,7 @@ devlink_nl_reload_actions_performed_snd(struct devlink > *devlink, > > static int devlink_nl_cmd_reload(struct sk_buff *skb, struct genl_info *info) > { > + enum devlink_reload_limit limit; > struct devli

[PATCH net-next 03/16] devlink: Add devlink reload limit option

2020-10-01 Thread Moshe Shemesh
Add reload limit to demand restrictions on reload actions. Reload limits supported: no_reset: No reset allowed, no down time allowed, no link flap and no configuration is lost. By default reload limit is unspecified and so no constrains on reload actions are required. Some combinations