Re: [EXT] Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-21 Thread David Miller
From: Jakub Kicinski Date: Thu, 21 May 2020 12:11:56 -0700 > Module parameters are very strongly discouraged for networking drivers. I fundamentally will disallow them except in very narrowly scoped cases. Make a real API in the kernel for what you are trying to do, or you can't support the fac

Re: [EXT] Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-21 Thread Igor Russkikh
>> Right now we really aren't sure we can dynamically rearrange >> resources between QoS and PTP, since disabling/enabling PTP requires >> a complete HW reconfiguration unfortunately. Even more unfortunate is >> the fact that we can't change the TC, which is reserved for PTP, >> because TC2 is ha

Re: [EXT] Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-21 Thread Jakub Kicinski
On Thu, 21 May 2020 09:18:44 + Mark Starovoytov wrote: > Hi Jakub, > > > > In the first generation of our hardware (A1), a whole traffic class is > > > consumed for PTP handling in FW (FW uses it to send the ptp data and > > > to send back timestamps). > > > Since this conflicts with QoS (user

RE: [EXT] Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-21 Thread Mark Starovoytov
Hi Jakub, > > In the first generation of our hardware (A1), a whole traffic class is > > consumed for PTP handling in FW (FW uses it to send the ptp data and > > to send back timestamps). > > Since this conflicts with QoS (user is unable to use the reserved > > TC2), we suggest using module param

Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-20 Thread kbuild test robot
Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20200519] [cannot apply to net/master linus/master ipvs/master v5.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help imp

Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-20 Thread kbuild test robot
Hi Igor, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on net-next/master] [also build test WARNING on next-20200519] [cannot apply to net/master linus/master ipvs/master v5.7-rc6] [if your patch is applied to the wrong git tree, please drop us a note to help imp

Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-20 Thread Jakub Kicinski
On Wed, 20 May 2020 16:47:25 +0300 Igor Russkikh wrote: > From: Dmitry Bezrukov > > This patch contains the following changes: > * add cfg->is_ptp (used for PTP enable/disable switch, which > is described in more details below); > * add cfg->tc_mode (A1 supports 2 HW modes only); > * setup queu

Re: [PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-20 Thread Jakub Kicinski
On Wed, 20 May 2020 16:47:25 +0300 Igor Russkikh wrote: > From: Dmitry Bezrukov > > This patch contains the following changes: > * add cfg->is_ptp (used for PTP enable/disable switch, which > is described in more details below); > * add cfg->tc_mode (A1 supports 2 HW modes only); > * setup queu

[PATCH net-next 03/12] net: atlantic: changes for multi-TC support

2020-05-20 Thread Igor Russkikh
From: Dmitry Bezrukov This patch contains the following changes: * add cfg->is_ptp (used for PTP enable/disable switch, which is described in more details below); * add cfg->tc_mode (A1 supports 2 HW modes only); * setup queue to TC mapping based on TC mode on A2; * remove hw_tx_tc_mode_get / h