Re: [PATCH net-next 03/10] net: sparx5: add hostmode with phylink support

2021-04-20 Thread Steen.Hegelund
Hi Jacub, On Fri, 2021-04-16 at 14:22 -0700, Jakub Kicinski wrote: > EXTERNAL EMAIL: Do not click links or open attachments unless you know the > content is safe > > On Fri, 16 Apr 2021 15:16:50 +0200 Steen Hegelund wrote: > > +static int sparx5_set_mac_address(struct net_device *dev, void *p)

Re: [PATCH net-next 03/10] net: sparx5: add hostmode with phylink support

2021-04-16 Thread Jakub Kicinski
On Fri, 16 Apr 2021 15:16:50 +0200 Steen Hegelund wrote: > +static int sparx5_set_mac_address(struct net_device *dev, void *p) > +{ > + const struct sockaddr *addr = p; > + > + /* Record the address */ > + ether_addr_copy(dev->dev_addr, addr->sa_data); I think you need to validate that

[PATCH net-next 03/10] net: sparx5: add hostmode with phylink support

2021-04-16 Thread Steen Hegelund
This patch adds netdevs and phylink support for the ports in the switch. It also adds register based injection and extraction for these ports. Frame DMA support for injection and extraction will be added in a later series. Signed-off-by: Steen Hegelund Signed-off-by: Bjarni Jonasson Signed-off-