Re: [PATCH net-next 01/11] qede: Fix sparse warnings

2017-05-22 Thread David Miller
From: "Mintz, Yuval" Date: Mon, 22 May 2017 17:44:12 + >> >> Please. >> >> >> >> This is exactly the problem when such a terse commit message, or lack of >> >> any >> >> message at all as is the case here, occurs. >> >> >> >> I have no idea what removing this method assignment has to do wi

Re: [PATCH net-next 01/11] qede: Fix sparse warnings

2017-05-22 Thread Mintz, Yuval
> >> Please. > >> > >> This is exactly the problem when such a terse commit message, or lack of > >> any > >> message at all as is the case here, occurs. > >> > >> I have no idea what removing this method assignment has to do with fixing > >> sparse warnings. > > > > It's currently defined twic

Re: [PATCH net-next 01/11] qede: Fix sparse warnings

2017-05-22 Thread David Miller
From: "Mintz, Yuval" Date: Mon, 22 May 2017 16:48:25 + > > >> -Original Message- >> From: David Miller [mailto:da...@davemloft.net] >> Sent: Monday, May 22, 2017 7:38 PM >> To: Mintz, Yuval >> Cc: netdev@vger.kernel.org; Chopra, Manis

RE: [PATCH net-next 01/11] qede: Fix sparse warnings

2017-05-22 Thread Mintz, Yuval
> -Original Message- > From: David Miller [mailto:da...@davemloft.net] > Sent: Monday, May 22, 2017 7:38 PM > To: Mintz, Yuval > Cc: netdev@vger.kernel.org; Chopra, Manish > Subject: Re: [PATCH net-next 01/11] qede: Fix sparse warnings > > From: Yuval Mintz

Re: [PATCH net-next 01/11] qede: Fix sparse warnings

2017-05-22 Thread David Miller
From: Yuval Mintz Date: Mon, 22 May 2017 14:32:01 +0300 > From: Manish Chopra > > Signed-off-by: Manish Chopra > Signed-off-by: Yuval Mintz > --- > drivers/net/ethernet/qlogic/qede/qede_dcbnl.c | 1 - > drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 10 ++ > drivers/net/etherne

[PATCH net-next 01/11] qede: Fix sparse warnings

2017-05-22 Thread Yuval Mintz
From: Manish Chopra Signed-off-by: Manish Chopra Signed-off-by: Yuval Mintz --- drivers/net/ethernet/qlogic/qede/qede_dcbnl.c | 1 - drivers/net/ethernet/qlogic/qede/qede_ethtool.c | 10 ++ drivers/net/ethernet/qlogic/qede/qede_fp.c | 25 ++--- drivers/net/e