Re: [PATCH net-next 01/11] net: dsa: legacy: assign dst->applied

2017-08-14 Thread Andrew Lunn
On Mon, Aug 14, 2017 at 06:22:32PM -0400, Vivien Didelot wrote: > The "applied" boolean of the dsa_switch_tree is only set in the new > bindings. This patch sets it in the legacy code as well. What is missing here is: Why? I see the next patch does a WARN_ON(!applied). Why have a WARN_ON? And

[PATCH net-next 01/11] net: dsa: legacy: assign dst->applied

2017-08-14 Thread Vivien Didelot
The "applied" boolean of the dsa_switch_tree is only set in the new bindings. This patch sets it in the legacy code as well. Signed-off-by: Vivien Didelot --- net/dsa/legacy.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/net/dsa/legacy.c b/net/dsa/legacy.c index 91e6f7981d39..a6a084948