Re: [PATCH net-next 01/11] net: aquantia: PTP skeleton declarations and callbacks

2019-09-11 Thread Igor Russkikh
Hi Andrew, >> +struct ptp_clock *clock; >> +struct aq_ptp_s *self; > > I find the use of self in this code quite confusing. It does not > appear to have a clear meaning. It can be a aq_ring_s, aq_nic_c, > aq_hw_s, aq_vec_s. > > Looking at this code i always have to figure out what self

Re: [PATCH net-next 01/11] net: aquantia: PTP skeleton declarations and callbacks

2019-09-10 Thread Andrew Lunn
On Mon, Sep 09, 2019 at 01:38:38PM +, Igor Russkikh wrote: > From: Dmitry Bezrukov Hi Igor, et al. > @@ -331,6 +332,10 @@ int aq_nic_init(struct aq_nic_s *self) > self->aq_vecs > i; ++i, aq_vec = self->aq_vec[i]) > aq_vec_init(aq_vec, self->aq_hw_ops, self->aq_hw)

[PATCH net-next 01/11] net: aquantia: PTP skeleton declarations and callbacks

2019-09-09 Thread Igor Russkikh
From: Dmitry Bezrukov Here we add basic function for PTP clock register/unregister. We also declare FW/HW capability bits used to control PTP feature on device. PTP device is created if network card has appropriate FW that has PTP enabled in config. HW supports timestamping for PTPv2 802.AS1 and